Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4297

obs_decam tests/getId.py fails

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_decam
    • Labels:
      None

      Description

      In DM-4191, I included a change in DecamMapper._computeCcdExposureId: https://github.com/lsst/obs_decam/commit/08086d2a961ba7cef34f4a33acba1f6be356e25f
      but missed to update the unit test getId.py accordingly.

      More about that previous change in DecamMapper._computeCcdExposureId:
      It actually wasn't directly relevant to ISR processing but was from conversations in HipChat obs_decam room Oct 21, 2015, 1:05 PM CDT

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4191 Initial code change to run ISR with DECam raw data

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Lauren MacArthur, may you please review this 1-line fix in obs_decam/tests/getId.py on branch tickets/DM-4297 ?

            I edited DecamMapper._computeCcdExposureId but missed to update the unit test.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Lauren MacArthur , may you please review this 1-line fix in obs_decam/tests/getId.py on branch tickets/ DM-4297 ? I edited DecamMapper._computeCcdExposureId but missed to update the unit test.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Looks good (I guess we all need occasional reminding to re-build & run the tests after even seemingly trivial changes!)

            Show
            lauren Lauren MacArthur added a comment - Looks good (I guess we all need occasional reminding to re-build & run the tests after even seemingly trivial changes!)
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Very true!!

            Thank you for your review!

            Change merged.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Very true!! Thank you for your review! Change merged.

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Lauren MacArthur
              Watchers:
              Hsin-Fang Chiang, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.