Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-430

Control log levels on a per-plugin basis

    Details

    • Story Points:
      4
    • Sprint:
      DRP S17-4, DRP S17-5
    • Team:
      Data Release Production

      Description

      We should be able to control log levels so that certain plugins are run at one level while the rest are run at another (to allow a particular plugin being debugged to be more verbose).

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            This change only involves meas_base (tickets/DM-430)

            While there are 6 other packages which create Algorithms or plugins, I made the decision not to add a "logName" initializer to those plugins since none of them actually log. Logging is done for them by baseMeasurement.py when they are run as part of a measurement task, which is what this ticket originally asked for. The logName used by measurement only needs to be propagated to the plugin if the plugin actually want to log things for itself.

            The only C++ plugin which currently logs is PsfFlux, which has been set up as an example. Please note the addition to mainpage.dox to describe the procedure for adding logging to plugins where desired.

            Show
            pgee Perry Gee added a comment - This change only involves meas_base (tickets/ DM-430 ) While there are 6 other packages which create Algorithms or plugins, I made the decision not to add a "logName" initializer to those plugins since none of them actually log. Logging is done for them by baseMeasurement.py when they are run as part of a measurement task, which is what this ticket originally asked for. The logName used by measurement only needs to be propagated to the plugin if the plugin actually want to log things for itself. The only C++ plugin which currently logs is PsfFlux, which has been set up as an example. Please note the addition to mainpage.dox to describe the procedure for adding logging to plugins where desired.
            Hide
            rearmstr Bob Armstrong added a comment -

            Only a few minor style issues, I indicated on the pull request.

            I didn't see any updates to the doxygen page you mentioned. Those would be useful.

            Show
            rearmstr Bob Armstrong added a comment - Only a few minor style issues, I indicated on the pull request. I didn't see any updates to the doxygen page you mentioned. Those would be useful.
            Hide
            pgee Perry Gee added a comment -

            Bob Armstrong I guess I rebased over the mainpage.dox checkin by accident. I did the doc on my portable. I will push the doxygen page as soon as I get home. I would like you to review it.

            Show
            pgee Perry Gee added a comment - Bob Armstrong I guess I rebased over the mainpage.dox checkin by accident. I did the doc on my portable. I will push the doxygen page as soon as I get home. I would like you to review it.
            Hide
            pgee Perry Gee added a comment -

            Bob ArmstrongI pushed the mainpage.dox to tickets/DM-430

            Show
            pgee Perry Gee added a comment - Bob Armstrong I pushed the mainpage.dox to tickets/ DM-430
            Hide
            pgee Perry Gee added a comment -

            I've decided to move the doc change to DM-9574, where a few changes also have to be made to the plugin logging.

            Show
            pgee Perry Gee added a comment - I've decided to move the doc change to DM-9574 , where a few changes also have to be made to the plugin logging.

              People

              • Assignee:
                pgee Perry Gee
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Bob Armstrong
                Watchers:
                Bob Armstrong, Jim Bosch, Perry Gee
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel