Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4302

update obs_lsstSim

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6, Alert Production X16 - 03, Alert Production X16 - 04
    • Team:
      Alert Production

      Description

      obs_lsstSim has seen some bitrot. In particular, the ingest task and the addition of the getExposureId methods on processImageTask have not been propagated to obs_lsstSim. This ticket will deal with those issues.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-5758 processEimage.py raises various errors in .calibrate.measureApCorr

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-5735 butler.subset problems with obs_lsstSim

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            DM-5758 should be closed when this is closed since DM-5758 has been merged with this ticket.

            Show
            krughoff Simon Krughoff added a comment - DM-5758 should be closed when this is closed since DM-5758 has been merged with this ticket.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            I think this is ready for review. This requires a recent build of pipe_tasks to include a merged ticket from this morning (20 April).

            Jim, can you look at this and make sure it works as you expect?

            Show
            krughoff Simon Krughoff added a comment - I think this is ready for review. This requires a recent build of pipe_tasks to include a merged ticket from this morning (20 April). Jim, can you look at this and make sure it works as you expect?
            Hide
            Permalink
            jchiang James Chiang added a comment -

            I'm not sure I would be the best person to do the review, despite my interest in making sure everything works for Twinkles. I'm not very familiar with a lot of the code in this package, but I'll do it if there's a problem finding someone else. Can you open a PR so that I can see which files are at issue?

            Show
            jchiang James Chiang added a comment - I'm not sure I would be the best person to do the review, despite my interest in making sure everything works for Twinkles. I'm not very familiar with a lot of the code in this package, but I'll do it if there's a problem finding someone else. Can you open a PR so that I can see which files are at issue?
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            PR opened.

            Show
            krughoff Simon Krughoff added a comment - PR opened.
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            Hsin-Fang Chiang Do you mind looking over these changes to make sure I didn't do anything too silly. The tests pass and I can reduce data on my machine, so I think it's mostly a case of just making sure I'm not doing anything wrong.

            Show
            krughoff Simon Krughoff added a comment - Hsin-Fang Chiang Do you mind looking over these changes to make sure I didn't do anything too silly. The tests pass and I can reduce data on my machine, so I think it's mostly a case of just making sure I'm not doing anything wrong.
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            I didn't try to run any data but the code changes look fine to me. I left some comments on the PR.

            Also noticed there is a obs_lsstSim/tests/data/registry.sqlite3 file, does it need to be updated with these changes?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - I didn't try to run any data but the code changes look fine to me. I left some comments on the PR. Also noticed there is a obs_lsstSim/tests/data/registry.sqlite3 file, does it need to be updated with these changes?
            Hide
            Permalink
            krughoff Simon Krughoff added a comment -

            I don't believe the registry needs to be updated. I didn't really touch the tests.

            I addressed the concerns and merged.

            Show
            krughoff Simon Krughoff added a comment - I don't believe the registry needs to be updated. I didn't really touch the tests. I addressed the concerns and merged.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Chris Walter, Hsin-Fang Chiang, James Chiang, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.