Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:
-
Story Points:1
-
Epic Link:
-
Team:Alert Production
Description
A recent update to assembleCoadd to bring over changes to do clipped coadds breaks coadd generation. There are two specific problems.
1. There is an infinite recursion because of SafeClipAssembleCoaddTask calling its own constructor in the __init__ method.
2. The overridden assemble method does not adhere to the original assemble call signature, so when the default run method is called by ParseAndRun, it raises an exception.
Additionally I find the flow fairly confusing as the overridden assemble method is called by the default run method which then calls the default assemble method on the parent class.
Attachments
Issue Links
- relates to
-
DM-4307 Please add HSC tests to CI
- Done
Activity
This looks great.
I have two small requests for the doc string of SafeClipAssembleCoaddTask.assemble:
- document that args and *kwargs are ignored
- correct the spelling of "vists" to "visits"
Merged prematurely, so made the doc changes on master.
Simon Krughoff: There's no ticket which explicitly requests that this task code be refactored. We have DM-3581, an epic, which covers re-working our top level tasks post HSC-merge; I've added a note there that we should specifically consider AssembleCoadd when we do so.
Looks like this was merged many years ago.
John Swinbank Thanks for looking. Both of those tickets will help. Did you capture the need for a refactor anywhere?