Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4318

Mention self-merge for repos.yaml in documents

    XMLWordPrintable

    Details

      Description

      The conclusion of RFC-75 asks for the process to be documented in https://confluence.lsstcorp.org/display/LDMDG/Adding+a+new+package+to+the+build. Please do so.

        Attachments

          Issue Links

            Activity

            No builds found.
            ktl Kian-Tat Lim created issue -
            Hide
            swinbank John Swinbank added a comment -

            Before I found this issue, I added a brief note to Confluence myself. Joshua Hoblitt may wish to expand, correct or replace what I've written.

            Show
            swinbank John Swinbank added a comment - Before I found this issue, I added a brief note to Confluence myself. Joshua Hoblitt may wish to expand, correct or replace what I've written.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            I swear added a blurb to developer guide long ago but it appears to have been lost...

            Show
            jhoblitt Joshua Hoblitt added a comment - I swear added a blurb to developer guide long ago but it appears to have been lost...
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            Looks like my blurb has been lost to the either. John Swinbank thanks for putting those notes together – I don't think I can add much to that.

            Jonathan Sick Do you want to sit down at some point to go over what John Swinbank posted?

            Show
            jhoblitt Joshua Hoblitt added a comment - Looks like my blurb has been lost to the either. John Swinbank thanks for putting those notes together – I don't think I can add much to that. Jonathan Sick Do you want to sit down at some point to go over what John Swinbank posted?
            Hide
            ktl Kian-Tat Lim added a comment -

            I'd prefer to have the policy/procedure documents be self-contained rather than referring to RFCs (except perhaps for reasoning or background), so I think John Swinbank's modification still needs to be expanded a bit.

            Show
            ktl Kian-Tat Lim added a comment - I'd prefer to have the policy/procedure documents be self-contained rather than referring to RFCs (except perhaps for reasoning or background), so I think John Swinbank 's modification still needs to be expanded a bit.
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-75 [ RFC-75 ]
            jbecla Jacek Becla made changes -
            Team SQuaRE [ 10302 ]
            Hide
            jsick Jonathan Sick added a comment - - edited

            Sorry, I just found this ticket. Yes, the self-merge policy is technically documented in https://developer.lsst.io/build-ci/new_package.html :

            The new package must be added to the etc/repos.yaml file in the lsstsw package along with its corresponding GitHub URL. This file is governed by a “self-merge” policy: upon opening a pull request, it will be checked by the Travis CI system, and developers may merge without further review on success. Refer to RFC-75 for background.

            But I think I can restructure that page a bit to make the process easier to follow and have policies more clearly defined. I'll take the ticket on.

            Show
            jsick Jonathan Sick added a comment - - edited Sorry, I just found this ticket. Yes, the self-merge policy is technically documented in https://developer.lsst.io/build-ci/new_package.html : The new package must be added to the etc/repos.yaml file in the lsstsw package along with its corresponding GitHub URL. This file is governed by a “self-merge” policy: upon opening a pull request, it will be checked by the Travis CI system, and developers may merge without further review on success. Refer to RFC-75 for background. But I think I can restructure that page a bit to make the process easier to follow and have policies more clearly defined. I'll take the ticket on.
            jsick Jonathan Sick made changes -
            Assignee Joshua Hoblitt [ jhoblitt ] Jonathan Sick [ jsick ]
            jsick Jonathan Sick made changes -
            Epic Link DM-8445 [ 28061 ]
            tjenness Tim Jenness made changes -
            Labels dm-dev-guide
            jsick Jonathan Sick made changes -
            Epic Link DM-8445 [ 28061 ] DM-5403 [ 23210 ]
            jsick Jonathan Sick made changes -
            Link This issue relates to DM-9734 [ DM-9734 ]
            Show
            jhoblitt Joshua Hoblitt added a comment - Is this issue resolved by https://developer.lsst.io/build-ci/new_package.html#adding-a-new-package-to-the-build  ?
            tjenness Tim Jenness made changes -
            Remote Link This issue links to "Page (Confluence)" [ 31017 ]
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]
            Hide
            tjenness Tim Jenness added a comment -
            Show
            tjenness Tim Jenness added a comment - This has been done already: see https://developer.lsst.io/stack/adding-a-new-package.html

              People

              Assignee:
              jsick Jonathan Sick
              Reporter:
              ktl Kian-Tat Lim
              Watchers:
              Jonathan Sick, Joshua Hoblitt, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.