Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4319

obs_subaru uses envAppend when the common usage is envPrepend

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      In DM-868 we fixed the table files to use envPrepend rather than envAppend. obs_subaru was not around at the time so it still needs to be fixed.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Tim Jenness, would you please review this trivial change?

            price@price-laptop:~/LSST/obs/subaru (tickets/DM-4319=) $ git sub-patch
            commit 14a2c6d0ee81881378e58136d2dafcf05f0d03cb
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed Nov 11 17:07:36 2015 -0500
             
                ups: prepend instead of append to envvars
                
                Prepending makes the newly setup package preferred to anything
                else in the environment.
             
            diff --git a/ups/obs_subaru.table b/ups/obs_subaru.table
            index ec4a48c..da77dcd 100644
            --- a/ups/obs_subaru.table
            +++ b/ups/obs_subaru.table
            @@ -16,7 +16,7 @@ setupOptional(suprime_data)
             setupOptional(testdata_subaru)
             
             envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
            -envAppend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
            -envAppend(PYTHONPATH, ${PRODUCT_DIR}/python)
            -envAppend(PATH, ${PRODUCT_DIR}/bin)
            +envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib)
            +envPrepend(PYTHONPATH, ${PRODUCT_DIR}/python)
            +envPrepend(PATH, ${PRODUCT_DIR}/bin)
             
            

            Show
            price Paul Price added a comment - Tim Jenness , would you please review this trivial change? price@price-laptop:~/LSST/obs/subaru (tickets/DM-4319=) $ git sub-patch commit 14a2c6d0ee81881378e58136d2dafcf05f0d03cb Author: Paul Price <price@astro.princeton.edu> Date: Wed Nov 11 17:07:36 2015 -0500   ups: prepend instead of append to envvars Prepending makes the newly setup package preferred to anything else in the environment.   diff --git a/ups/obs_subaru.table b/ups/obs_subaru.table index ec4a48c..da77dcd 100644 --- a/ups/obs_subaru.table +++ b/ups/obs_subaru.table @@ -16,7 +16,7 @@ setupOptional(suprime_data) setupOptional(testdata_subaru) envPrepend(LD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) -envAppend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) -envAppend(PYTHONPATH, ${PRODUCT_DIR}/python) -envAppend(PATH, ${PRODUCT_DIR}/bin) +envPrepend(DYLD_LIBRARY_PATH, ${PRODUCT_DIR}/lib) +envPrepend(PYTHONPATH, ${PRODUCT_DIR}/python) +envPrepend(PATH, ${PRODUCT_DIR}/bin)
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me.

            Show
            tjenness Tim Jenness added a comment - Looks good to me.
            Hide
            price Paul Price added a comment -

            Thanks.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks. Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Tim Jenness
                Watchers:
                Paul Price, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel