Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4329

Coadd_utils tests should run and skip if afwdata is missing

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: coadd_utils
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Architecture

      Description

      Currently, the coadd_utils tests are completely skipped at the scons layer if afwdata can not be located. This is bad for two reasons:
      1. Are there any tests that can be run even if afwdata is missing?.
      2. When we switch to a proper test harness (e.g. DM-3901) an important metric is the number of tests executed compared with the number of tests skipped.
      Each test file (or even each test) should determine itself whether it should be skipped based on afwdata availability. This should not be a global switch.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-4358 obs_subaru tests should skip within the tests if test data can not be located

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5561 Write tech note on modifications required to use py.test framework

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-609 afw unit tests not built unless afwdata available

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-4328 AFW tests should run and skip if afwdata is missing

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            A quick look at the tests indicates that only 2 of the 5 test scripts use afwdata.

            Show
            tjenness Tim Jenness added a comment - A quick look at the tests indicates that only 2 of the 5 test scripts use afwdata .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Minor changes to explicitly skip the 5 of 12 tests that really needed afwdata rather than skipping all the tests.

            Show
            tjenness Tim Jenness added a comment - Minor changes to explicitly skip the 5 of 12 tests that really needed afwdata rather than skipping all the tests.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Looks good. Thanks for taking care of this.

            Show
            swinbank John Swinbank added a comment - Looks good. Thanks for taking care of this.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thanks. Merged.

            Show
            tjenness Tim Jenness added a comment - Thanks. Merged.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: