Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4358

obs_subaru tests should skip within the tests if test data can not be located

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Story Points:
      0.1
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6
    • Team:
      Data Release Production

      Description

      Currently, the obs_subaru tests are completely skipped at the scons layer if the test data can not be located. This is bad for two reasons:
      1. Are there any tests that can be run even if test data is missing?.
      2. When we switch to a proper test harness (e.g. DM-3901) an important metric is the number of tests executed compared with the number of tests skipped.
      Each test file (or even each test) should determine itself whether it should be skipped based on afwdata availability. This should not be a global switch.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3518 prune stale obs_subaru dependencies

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-4329 Coadd_utils tests should run and skip if afwdata is missing

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-609 afw unit tests not built unless afwdata available

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            John Swinbank I think this ticket can be closed. It seems that global test aborting was removed in commit 17e3eaa803961c2b992a14d2c1578aed23745af7 at the end of December.

            Show
            tjenness Tim Jenness added a comment - John Swinbank I think this ticket can be closed. It seems that global test aborting was removed in commit 17e3eaa803961c2b992a14d2c1578aed23745af7 at the end of December.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Good catch, thanks.

            Show
            swinbank John Swinbank added a comment - Good catch, thanks.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Fixed on DM-3518.

            Show
            swinbank John Swinbank added a comment - Fixed on DM-3518 .
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Done as part of DM-3518.

            Show
            swinbank John Swinbank added a comment - Done as part of DM-3518 .

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              tjenness Tim Jenness
              Watchers:
              John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.