Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4361

obs_sdss fails tests trying to import six

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_sdss
    • Labels:
      None
    • Team:
      Data Release Production

      Description

      Installing lsst_apps -t w_2015_45 fails with

      ERROR: ImportError: cannot import name six [unknown]
      Traceback (most recent call last):
        File "tests/getId.py", line 29, in <module>
          from lsst.obs.sdss import SdssMapper
        File "/Users/lsst/products/EupsBuildDir/DarwinX86/obs_sdss-11.0-3-g1664b15+1/obs_sdss-11.0-3-g1664b15+1/python/lsst/obs/sdss/__init__.py", line 24, in <module>
          import makeCamera
        File "/Users/lsst/products/EupsBuildDir/DarwinX86/obs_sdss-11.0-3-g1664b15+1/obs_sdss-11.0-3-g1664b15+1/python/lsst/obs/sdss/makeCamera.py", line 30, in <module>
          from lsst.obs.sdss.convertOpECalib import SdssCameraState
        File "/Users/lsst/products/EupsBuildDir/DarwinX86/obs_sdss-11.0-3-g1664b15+1/obs_sdss-11.0-3-g1664b15+1/python/lsst/obs/sdss/convertOpECalib.py", line 4, in <module>
          from lsst.obs.sdss.yanny import yanny as Yanny
        File "/Users/lsst/products/EupsBuildDir/DarwinX86/obs_sdss-11.0-3-g1664b15+1/obs_sdss-11.0-3-g1664b15+1/python/lsst/obs/sdss/yanny.py", line 35, in <module>
          from astropy.extern import six
      ImportError: cannot import name six
      

        Attachments

          Issue Links

            Activity

            No builds found.
            rhl Robert Lupton created issue -
            Hide
            tjenness Tim Jenness added a comment -

            Is this breakage from DM-4032? Looks like the new yanny reader brought in an undisclosed astropy dependency. Not good.

            Show
            tjenness Tim Jenness added a comment - Is this breakage from DM-4032 ? Looks like the new yanny reader brought in an undisclosed astropy dependency. Not good.
            Hide
            price Paul Price added a comment -

            Usage of astropy has snuck in via an update to Yanny (DM-4032); it should be easy to remove as it's not used much.

            John Swinbank points out that astropy is also used in daf_butlerUtils (DM-4170).

            These uses of astropy either need to be approved via the RFC process, or removed.

            Show
            price Paul Price added a comment - Usage of astropy has snuck in via an update to Yanny ( DM-4032 ); it should be easy to remove as it's not used much. John Swinbank points out that astropy is also used in daf_butlerUtils ( DM-4170 ). These uses of astropy either need to be approved via the RFC process, or removed.
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Team Data Release Production [ 10301 ]
            Hide
            tjenness Tim Jenness added a comment -

            We don't notice these things because astropy was added to the Jenkins dependency tree for Sims and newinstall.sh uses anaconda (which comes with astropy). (Joshua Hoblitt will be mumbling "I told you so" at this point).

            Show
            tjenness Tim Jenness added a comment - We don't notice these things because astropy was added to the Jenkins dependency tree for Sims and newinstall.sh uses anaconda (which comes with astropy ). ( Joshua Hoblitt will be mumbling "I told you so" at this point).
            Hide
            Parejkoj John Parejko added a comment -

            Oog. Sorry about that! The intention was not to bring in astropy in this case. I forgot that six is an astropy.extern package. I do wonder why it didn't fail in my original jenkins build, which I thought was before astropy was added to Jenkins.

            I can try to clean out the six references: there's only a couple.

            Show
            Parejkoj John Parejko added a comment - Oog. Sorry about that! The intention was not to bring in astropy in this case. I forgot that six is an astropy.extern package. I do wonder why it didn't fail in my original jenkins build, which I thought was before astropy was added to Jenkins. I can try to clean out the six references: there's only a couple.
            Hide
            Parejkoj John Parejko added a comment -

            I'll sort this out, since I made the mess.

            Show
            Parejkoj John Parejko added a comment - I'll sort this out, since I made the mess.
            Parejkoj John Parejko made changes -
            Assignee John Parejko [ parejkoj ]
            Hide
            Parejkoj John Parejko added a comment -

            Should be fixed in tickets/DM-4361 branch. Can someone else please check to be sure?

            Show
            Parejkoj John Parejko added a comment - Should be fixed in tickets/ DM-4361 branch. Can someone else please check to be sure?
            Hide
            Parejkoj John Parejko added a comment -

            Since you discovered it, can you please test it?

            Show
            Parejkoj John Parejko added a comment - Since you discovered it, can you please test it?
            Parejkoj John Parejko made changes -
            Reviewers Robert Lupton [ rhl ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-3591 [ DM-3591 ]
            Hide
            Parejkoj John Parejko added a comment -

            Anyone object to the merge request?

            https://github.com/lsst/obs_sdss/pull/5

            Show
            Parejkoj John Parejko added a comment - Anyone object to the merge request? https://github.com/lsst/obs_sdss/pull/5
            Hide
            tjenness Tim Jenness added a comment -

            Fine with me.

            Show
            tjenness Tim Jenness added a comment - Fine with me.
            Hide
            npease Nate Pease [X] (Inactive) added a comment -

            Show
            npease Nate Pease [X] (Inactive) added a comment -
            Hide
            Parejkoj John Parejko added a comment -

            Changes merged, builds should not have trouble with missing astropy now.

            Show
            Parejkoj John Parejko added a comment - Changes merged, builds should not have trouble with missing astropy now.
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status In Review [ 10004 ] Done [ 10002 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Robert Lupton
              Watchers:
              John Parejko, John Swinbank, Kian-Tat Lim, Nate Pease [X] (Inactive), Paul Price, Robert Lupton, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.