Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4386

Clean up ProcessCcdDecam

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_decam
    • Labels:
      None

      Description

      ProcessCcdDecam needs some cleanup:

      • run method simply delegates to the base class
      • propagateCalibFlags is a no-op (deliberately in cab69086, need to explore if the original problem still exists)
      • The config overrides (in config/processCcdDecam.py):
        • Uses the catalog star selector, which isn't wise given the current heterogeneity of reference catalogs.
        • Sets the background undersampleStype to REDUCE_INTERP_ORDER, which is the default.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Hsin-Fang Chiang, would you review these commits please?

            price@price-laptop:~/LSST/obs/decam (tickets/DM-4386=) $ git sub
            commit 081fe66b394aa8043063f9da6d1ac707790f6fa0
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Nov 19 13:04:23 2015 -0500
             
                ProcessCcdDecamTask: remove elements that don't modify parent class
                
                Including these adds confusion and unnecessary maintenance.
             
             python/lsst/obs/decam/processCcdDecam.py | 21 ---------------------
             1 file changed, 21 deletions(-)
             
            commit 87cd75afbdf41ab63ab5561bfec989fd1bc9ccee
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Nov 19 13:19:39 2015 -0500
             
                ProcessCcdDecamTask: remove workaround for flag propagation
                
                This workaround was added due to problems with propagating flags from the
                calibration pass.  We believe it has been fixed in DM-3174 and/or DM-3183.
             
             python/lsst/obs/decam/processCcdDecam.py | 4 ----
             1 file changed, 4 deletions(-)
             
            commit d17427411e657c872c4ccb3503f8c8018277ddb3
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Nov 19 13:24:36 2015 -0500
             
                config: remove bad and duplicate settings
                
                Using the catalog star selector is not a good choice for all users
                because of the heterogeneity of reference catalogs.
                Using duplicate (same as the default) settings can cause confusion.
             
             config/processCcdDecam.py | 4 ----
             1 file changed, 4 deletions(-)
            

            Show
            price Paul Price added a comment - Hsin-Fang Chiang , would you review these commits please? price@price-laptop:~/LSST/obs/decam (tickets/DM-4386=) $ git sub commit 081fe66b394aa8043063f9da6d1ac707790f6fa0 Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 19 13:04:23 2015 -0500   ProcessCcdDecamTask: remove elements that don't modify parent class Including these adds confusion and unnecessary maintenance.   python/lsst/obs/decam/processCcdDecam.py | 21 --------------------- 1 file changed, 21 deletions(-)   commit 87cd75afbdf41ab63ab5561bfec989fd1bc9ccee Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 19 13:19:39 2015 -0500   ProcessCcdDecamTask: remove workaround for flag propagation This workaround was added due to problems with propagating flags from the calibration pass. We believe it has been fixed in DM-3174 and/or DM-3183.   python/lsst/obs/decam/processCcdDecam.py | 4 ---- 1 file changed, 4 deletions(-)   commit d17427411e657c872c4ccb3503f8c8018277ddb3 Author: Paul Price <price@astro.princeton.edu> Date: Thu Nov 19 13:24:36 2015 -0500   config: remove bad and duplicate settings Using the catalog star selector is not a good choice for all users because of the heterogeneity of reference catalogs. Using duplicate (same as the default) settings can cause confusion.   config/processCcdDecam.py | 4 ---- 1 file changed, 4 deletions(-)
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            All changes look good and free to merge.

            Tried running processCcdDecam.py with default config (only with obs_decam/config/processCcdDecam.py override) and it ran all the way through. Tried processing one visit with astrometry_net_data sdss_dr8 and another one with 2mass; both went through.

            Below is beyond this ticket...
            This makes me think more about DM-4077, where a --preprocessed argument may be wanted for ProcessCcdTask. In the case of DECam data, I guess they want processCcd.py repo to do raw data processing, and processCcd.py repo --preprocessed instcal to do processing starting with instcal post-ISR data. Currently the latter is done by processCcdDecam.py repo. Looking at the minimalist override, DM-4077 might just need a little bit tweaking in ProcessCcdTask...

            Show
            hchiang2 Hsin-Fang Chiang added a comment - All changes look good and free to merge. Tried running processCcdDecam.py with default config (only with obs_decam/config/processCcdDecam.py override) and it ran all the way through. Tried processing one visit with astrometry_net_data sdss_dr8 and another one with 2mass; both went through. Below is beyond this ticket... This makes me think more about DM-4077 , where a --preprocessed argument may be wanted for ProcessCcdTask . In the case of DECam data, I guess they want processCcd.py repo to do raw data processing, and processCcd.py repo --preprocessed instcal to do processing starting with instcal post-ISR data. Currently the latter is done by processCcdDecam.py repo . Looking at the minimalist override, DM-4077 might just need a little bit tweaking in ProcessCcdTask ...
            Hide
            price Paul Price added a comment -

            Thanks!

            Merged to master.

            Show
            price Paul Price added a comment - Thanks! Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Hsin-Fang Chiang
                Watchers:
                David Nidever [X] (Inactive), Hsin-Fang Chiang, Paul Price, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel