Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4410

Port detection task footprint growth changes from HSC

    XMLWordPrintable

    Details

    • Story Points:
      5
    • Sprint:
      Science Pipelines DM-W16-3, Science Pipelines DM-W16-4, Science Pipelines DM-W16-5
    • Team:
      Data Release Production

      Description

      In hsc the default behavior for the detection task is to updated footprints with a footprint which has been grown by the psf. This behavior needs to be ported to LSST, as some source records have footprints which are too small. When making this change, the new default needs to be overridden for the calibrateTask, as it needs the original size.

      The port includes 8e9fb159a3227f848e0db1ecacf7819599f1c03b from meas_algorithms and 8bf0f4a44c924259d9eefbd109aadec7d839e0f2 from pipe_tasks

        Attachments

          Issue Links

            Activity

            Hide
            rearmstr Bob Armstrong added a comment -

            A couple of remaining questions:

            • Why is the deblender turned off for calibrate task?
            • In calibrate task you return the original footprints, but the detection mask is still grown. Is this the behavior we want? I know I've been caught by this feature before.
            Show
            rearmstr Bob Armstrong added a comment - A couple of remaining questions: Why is the deblender turned off for calibrate task? In calibrate task you return the original footprints, but the detection mask is still grown. Is this the behavior we want? I know I've been caught by this feature before.
            Hide
            nlust Nate Lust added a comment -

            Deblender is turned off for now as calibrate task has no real way to use it, that will be changed with an upcoming change to the deblender.

            Confirmed with Jim that this is the behavior we want. The point will be irrelevant once the calibrate task is changed in any event.

            Show
            nlust Nate Lust added a comment - Deblender is turned off for now as calibrate task has no real way to use it, that will be changed with an upcoming change to the deblender. Confirmed with Jim that this is the behavior we want. The point will be irrelevant once the calibrate task is changed in any event.
            Hide
            swinbank John Swinbank added a comment -

            Can you say a bit more about upcoming changes to the deblender (ie, provide a link to the relevant ticket or other documentation if possible – if not, encourage Jim Bosch to create one!).

            Show
            swinbank John Swinbank added a comment - Can you say a bit more about upcoming changes to the deblender (ie, provide a link to the relevant ticket or other documentation if possible – if not, encourage Jim Bosch to create one!).
            Hide
            jbosch Jim Bosch added a comment -

            I don't think deblender behavior or pending changes are involved here; Nate Lust and I must have miscommunicated on that. But the net result is the same: I just don't want to bother adding the deblender to the current version of CalibrateTask right now, since Russell Owen's already working on a new version that will include it soon.

            Show
            jbosch Jim Bosch added a comment - I don't think deblender behavior or pending changes are involved here; Nate Lust and I must have miscommunicated on that. But the net result is the same: I just don't want to bother adding the deblender to the current version of CalibrateTask right now, since Russell Owen 's already working on a new version that will include it soon.
            Hide
            ctslater Colin Slater added a comment -

            ip_diffim looks fine. I couldn't find any other places where MaxPixels was referenced.

            Show
            ctslater Colin Slater added a comment - ip_diffim looks fine. I couldn't find any other places where MaxPixels was referenced.

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              nlust Nate Lust
              Reviewers:
              Bob Armstrong, Colin Slater, Jim Bosch
              Watchers:
              Bob Armstrong, Colin Slater, Jim Bosch, John Swinbank, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.