Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-449

Test Flux algorithms agains meas_algorithms

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Test for compatibility of NaiveFlux, GaussianFlux, and PsfFlux against meas_algorithms

        Attachments

          Issue Links

            Activity

            Hide
            pgee Perry Gee added a comment -

            This is actually going to be all of the remaining algorithms, as they are all tested with the same framework

            Show
            pgee Perry Gee added a comment - This is actually going to be all of the remaining algorithms, as they are all tested with the same framework
            Hide
            pgee Perry Gee added a comment -

            Because it is convenient to do so now, I have tested the following in addition to the main four (DM-445)

            GaussianFlux
            NaiveFlux
            classification
            PixelFlags
            skycoord

            Show
            pgee Perry Gee added a comment - Because it is convenient to do so now, I have tested the following in addition to the main four ( DM-445 ) GaussianFlux NaiveFlux classification PixelFlags skycoord
            Hide
            pgee Perry Gee added a comment -

            The meas_base algorithms were tested again the meas_algorithms using the test scripts in contrib/measComparison.git. The results over 4 different exposures from the measMosaicData set were identical, with the exception of PsfFlux. The tests were run with and without the configs.py configuration file, which alters the algorithm configs from defaults.

            I am making the fixing of this bug part of the review process.

            test1.py tests GaussianFlux, PsfFlux, SincFlux, and NaiveFlux

            test3.py tests skycoord, PixelFlags, classification

            classification fails in a few instances because of PsfFlux.

            The PsfFlux problems are as follows:

            1. An up to .1% variation in the flux measurement.
            2. A much larger variation in the flux error.
            3. A few cases where the old algorithm throws out and set the failure flag when the new algorithm does not. You can see these by running test3.py, since they show up in the test of classification

            Show
            pgee Perry Gee added a comment - The meas_base algorithms were tested again the meas_algorithms using the test scripts in contrib/measComparison.git. The results over 4 different exposures from the measMosaicData set were identical, with the exception of PsfFlux. The tests were run with and without the configs.py configuration file, which alters the algorithm configs from defaults. I am making the fixing of this bug part of the review process. test1.py tests GaussianFlux, PsfFlux, SincFlux, and NaiveFlux test3.py tests skycoord, PixelFlags, classification classification fails in a few instances because of PsfFlux. The PsfFlux problems are as follows: 1. An up to .1% variation in the flux measurement. 2. A much larger variation in the flux error. 3. A few cases where the old algorithm throws out and set the failure flag when the new algorithm does not. You can see these by running test3.py, since they show up in the test of classification
            Hide
            jbosch Jim Bosch added a comment -

            My understanding is that the code for this branch was combined with that of DM-445 on the tickets/DM-445 branches, so it's been reviewed as well. If that's not the case, please put this back into "In Review", and let me know what to look at.

            Show
            jbosch Jim Bosch added a comment - My understanding is that the code for this branch was combined with that of DM-445 on the tickets/ DM-445 branches, so it's been reviewed as well. If that's not the case, please put this back into "In Review", and let me know what to look at.

              People

              Assignee:
              pgee Perry Gee
              Reporter:
              pgee Perry Gee
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.