Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4531

add support for multiplication in the select statement

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      for example the following query should be supported:
      select sum(coord_ra*coord_ra) from qservTest_case03_qserv.RunDeepForcedSource;

        Attachments

          Issue Links

            Activity

            Hide
            womullan Wil O'Mullane added a comment -

            assume this was fixed but not closed ..close it,  change priority or in general take care of it.

            Show
            womullan Wil O'Mullane added a comment - assume this was fixed but not closed ..close it,  change priority or in general take care of it.
            Hide
            npease Nate Pease [X] (Inactive) added a comment -

            With the new/current (antlr4) parser this query no longer fails silently with incorrect results in qserv; it fails explicitly, because the antlr4 parser/IR factory rejects it: we have not added IR-creation support for multiplication in select yet (as in SELECT (a*b)). 

            I discussed this with Fritz Mueller in our team meeting, and I put a story point estimate on this issue, and changed the title & description to reflect the current work that needs to be done. We agreed this had been a critical bug because it was failing silently, returning incorrect results. Since now it fails explicitly and does not return results I changed the priority from critical to undefined. I changed it to a story: it's a feature we may need to support (needs to be prioritized & scheduled by Fritz), but was not part of the initial scope of work for the antlr4 parser conversion.

            Show
            npease Nate Pease [X] (Inactive) added a comment - With the new/current (antlr4) parser this query no longer fails silently with incorrect results in qserv; it fails explicitly, because the antlr4 parser/IR factory rejects it: we have not added IR-creation support for multiplication in select yet (as in SELECT (a*b) ).  I discussed this with Fritz Mueller in our team meeting, and I put a story point estimate on this issue, and changed the title & description to reflect the current work that needs to be done. We agreed this had been a critical bug because it was failing silently, returning incorrect results. Since now it fails explicitly and does not return results I changed the priority from critical to undefined. I changed it to a story: it's a feature we may need to support (needs to be prioritized & scheduled by Fritz), but was not part of the initial scope of work for the antlr4 parser conversion.
            Hide
            tjenness Tim Jenness added a comment -

            This is a special ticket in that it was mentioned as an old ticket in the very first DMCCB meeting and now, three years later, it as come up again at DMCCB as an old ticket...

            Show
            tjenness Tim Jenness added a comment - This is a special ticket in that it was mentioned as an old ticket in the very first DMCCB meeting and now, three years later, it as come up again at DMCCB as an old ticket...
            Hide
            fritzm Fritz Mueller added a comment -

            Still relevant, and still low priority...

            Show
            fritzm Fritz Mueller added a comment - Still relevant, and still low priority...
            Hide
            tjenness Tim Jenness added a comment -

            Maybe we'll talk again in 3 years...

            Show
            tjenness Tim Jenness added a comment - Maybe we'll talk again in 3 years...

              People

              Assignee:
              fritzm Fritz Mueller
              Reporter:
              salnikov Andy Salnikov
              Watchers:
              Andy Salnikov, Fritz Mueller, Jacek Becla, Nate Pease [X] (Inactive), Tim Jenness, Wil O'Mullane
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.