Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4534

shellcheck linting of lsstsw bash scripts

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Continuous Integration
    • Labels:
      None

      Description

      This issue is to recover a branch from DM-4113 that was not merged due to issues with installing shellcheck under travis.

        Attachments

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-1365 lsst-build should set or prompt for git author and e-mail if they're not specified

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-12436 remove jenkins py2 builds - post v15 release

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-4537 shellcheck linting of newinstall.sh

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4113 add lfs remote support to lsstsw/lsst_build

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            I've decided to hold off on merging this work until after the holiday season out of concern about unintended breakage.

            Show
            jhoblitt Joshua Hoblitt added a comment - I've decided to hold off on merging this work until after the holiday season out of concern about unintended breakage.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            It's been a year now. Are we abandoning this PR?

            Show
            tjenness Tim Jenness added a comment - It's been a year now. Are we abandoning this PR?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Joshua Hoblitt what's the plan for this ticket? Should it go back in TODO state? Should it be moved to WONT FIX? I see it's in an unscheduled epic (DM-5417) at the moment.

            Show
            tjenness Tim Jenness added a comment - Joshua Hoblitt what's the plan for this ticket? Should it go back in TODO state? Should it be moved to WONT FIX? I see it's in an unscheduled epic ( DM-5417 ) at the moment.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            This is in a backlog epic so at some point in the future we'll take another look at getting shellcheck to work under travis without jumping through a bunch of hoops. I will set it back to TODO.

            Show
            jhoblitt Joshua Hoblitt added a comment - This is in a backlog epic so at some point in the future we'll take another look at getting shellcheck to work under travis without jumping through a bunch of hoops. I will set it back to TODO.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            This was implemented/merged as part of DM-12436.

            Show
            jhoblitt Joshua Hoblitt added a comment - This was implemented/merged as part of DM-12436 .

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              jhoblitt Joshua Hoblitt
              Reviewers:
              Mario Juric, Tim Jenness
              Watchers:
              Frossie Economou, J Matt Peterson [X] (Inactive), Joshua Hoblitt, Mario Juric, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: