Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_modelfit
-
Labels:
-
Story Points:6
-
Epic Link:
-
Sprint:Measurement-S14-4
-
Team:Data Release Production
Description
The CModel code we want to transfer from HSC in DM-240 currently relies on the old "multishapelet.psf" algorithm in meas_extensions_multiShapelet. That means we either need to convert that PSF-to-shapelets code in meas_extensions_multiShapelet to use the meas_base interface, or we need add new PSF-to-shapelets code in meas_multifit.
I think the latter is the better choice, even if we delay DM-240 as a result; the heavy algorithmic code is already available as primitives in meas_multifit, so it should just be a matter of packing those into a simple driver, creating a config class for it, and testing it on a few real and simulated PSFs to learn reasonable defaults for the configs.
Attachments
Issue Links
- is blocked by
-
DM-674 fix handling of nested control objects
- Done
The new multishapelet PSF fitting code is now on branch u/jbosch/
DM-640of shapelet and meas_multifit (despite my earlier promise to the contrary, there is a small change to shapelet, but it is indeed really small - I changed a std::list to std::vector).It all seems to build against the LSST master stack, so
DM-641is at least mostly done, but you may find that the documentation is incomplete (everything that's there was done in the last 20 minutes), and the tests definitely are: there are unit tests for most of the trickier logic, but there actually isn't any test of the actual fitting. Improving that should be a part ofDM-641. We should dump a PSF image postage stamp or two in the git repository and then add the following tests to make use of it:I also haven't included any real error checking in the fitting code. I'm hoping we can get this to a state where it basically always succeeds if given a reasonable configuration, but the optimizer does output a lot of flags and we should check them for success before we return. That should be added as part of
DM-641as well.