# Bug fix and improvement for DECam processing

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
6
• Team:
Data Facility

#### Description

• Bug fix in DecamMapper policy of fringe dataset
• Bug fix on translating Community Pipeline's Bad Pixel Mask (BPM) — Previously in DM-4191 I looked up the wrong table for the BPM bit definition.
• Flag the potentially problematic edge pixels as SUSPECT (DM-4515)

#### Attachments

1. numEdgeSuspect30.png
215 kB
2. numEdgeSuspect35.png
216 kB

#### Activity

Hide
Simon Krughoff added a comment -

I'd say don't worry about a new ticket. I think, since we've added these to most obs packages by now anyway, we can just see how the tickets you mention work out.

Show
Simon Krughoff added a comment - I'd say don't worry about a new ticket. I think, since we've added these to most obs packages by now anyway, we can just see how the tickets you mention work out.
Hide
Hsin-Fang Chiang added a comment -

Simon Krughoff I wasn't sure if I understand your note on testing the edge bit setting. Do you mean testing if meas.algorithms.detection.SourceDetectionTask.setEdgeBits correctly does what it says? If so, I am thinking maybe that test would suit better in meas_algorithms?

Show
Hsin-Fang Chiang added a comment - Simon Krughoff I wasn't sure if I understand your note on testing the edge bit setting. Do you mean testing if meas.algorithms.detection.SourceDetectionTask.setEdgeBits correctly does what it says? If so, I am thinking maybe that test would suit better in meas_algorithms?
Hide
Hsin-Fang Chiang added a comment -

oops my force-push seemed to have eliminated your notes...

https://github.com/lsst/obs_decam/pull/13/files#diff-c8df75c8df81724a84a227b16263525bR145

Show
Hide
Hsin-Fang Chiang added a comment -

I added one line comment hopefully to make it more clear, so the previous link is now off by one line, but you get the idea.

Show
Hsin-Fang Chiang added a comment - I added one line comment hopefully to make it more clear, so the previous link is now off by one line, but you get the idea.
Hide
Hsin-Fang Chiang added a comment -

I merged the changes to master.

obs_decam

  README.md | 10 +-  examples/genDefectText.py | 49 ++++++++  policy/DecamMapper.paf | 225 ++++++++++++++++++++++++++++++++++-  python/lsst/obs/decam/decamMapper.py | 48 +++++++-  python/lsst/obs/decam/isr.py | 26 ++++  tests/getRaw.py | 2 +-  6 files changed, 351 insertions(+), 9 deletions(-) 

testdata_decam

  calib/calibRegistry.sqlite3 | 2 +-  calib/fringe/DECam_Master_20131115v1-zG_ci_z_01.fits | 3 +++  calib/fringe/DECam_Master_20131115v1-zG_ci_z_13.fits | 3 ---  3 files changed, 4 insertions(+), 4 deletions(-) 

I didn't add a test in meas.algorithms.detection.SourceDetectionTask.setEdgeBits. A new ticket may be filed. As for its use in obs.decam.isr, I added some comments in the code to describe what is going on there. Images were also visually inspected to check it does do what we intend. For example the attacked screenshots and were created with isr.numEdgeSuspect=30 and isr.numEdgeSuspect=35, respectively. Yellow is SUSPECT, red (which looks more like orange with my transparency setting) is BAD, and green is INTRP. The yellow mask covers 30 and 30 pixels wide as expected.

Show
Hsin-Fang Chiang added a comment - I merged the changes to master. obs_decam README.md | 10 +- examples/genDefectText.py | 49 ++++++++ policy/DecamMapper.paf | 225 ++++++++++++++++++++++++++++++++++- python/lsst/obs/decam/decamMapper.py | 48 +++++++- python/lsst/obs/decam/isr.py | 26 ++++ tests/getRaw.py | 2 +- 6 files changed, 351 insertions(+), 9 deletions(-) testdata_decam calib/calibRegistry.sqlite3 | 2 +- calib/fringe/DECam_Master_20131115v1-zG_ci_z_01.fits | 3 +++ calib/fringe/DECam_Master_20131115v1-zG_ci_z_13.fits | 3 --- 3 files changed, 4 insertions(+), 4 deletions(-) I didn't add a test in meas.algorithms.detection.SourceDetectionTask.setEdgeBits . A new ticket may be filed. As for its use in obs.decam.isr , I added some comments in the code to describe what is going on there. Images were also visually inspected to check it does do what we intend. For example the attacked screenshots and were created with isr.numEdgeSuspect=30 and isr.numEdgeSuspect=35 , respectively. Yellow is SUSPECT , red (which looks more like orange with my transparency setting) is BAD , and green is INTRP . The yellow mask covers 30 and 30 pixels wide as expected.

#### People

Assignee:
Hsin-Fang Chiang
Reporter:
Hsin-Fang Chiang
Reviewers:
Simon Krughoff
Watchers:
Colin Slater, Hsin-Fang Chiang, Simon Krughoff