Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4606

Support getting coordsys from a Coord

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Team:
      Alert Production

      Description

      Add getCoordSystem() to lsst::afw::Coord. Also add CoordSystem enum UNKNOWN = -1 (without changing the values of the existing enums) and make Coord a virtual base class.

      See RFC-118 for details. This ticket is intended to implement RFC-118 and so will be updated as required once RFC-118 is settled. (I filed this ticket before the RFC and then realized an RFC was required).

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            The primary changes are in afw:

            • Add CoordSystem enum UNKNOWN=-1 (all other values remain unchanged).
            • Add method getCoordSystem() to Coord and all subclasses.
            • Remove Coord::Ptr and similar typedefs in all coord classes. This required a few trivial change in each of two other packages, as well as more trivial changes in the afw package itself. Note: in every file I modified for this purpose, I eliminated use of ::Ptr and ::ConstPtr typedefs for all classes, for consistency.
            • Update a bit of code in afw to take advantage of UNKNOWN and getCoordSystem
            Show
            rowen Russell Owen added a comment - - edited The primary changes are in afw: Add CoordSystem enum UNKNOWN=-1 (all other values remain unchanged). Add method getCoordSystem() to Coord and all subclasses. Remove Coord::Ptr and similar typedefs in all coord classes. This required a few trivial change in each of two other packages, as well as more trivial changes in the afw package itself. Note: in every file I modified for this purpose, I eliminated use of ::Ptr and ::ConstPtr typedefs for all classes, for consistency. Update a bit of code in afw to take advantage of UNKNOWN and getCoordSystem
            Hide
            tjenness Tim Jenness added a comment -

            Looks like a worthwhile cleanup.

            Show
            tjenness Tim Jenness added a comment - Looks like a worthwhile cleanup.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the quick review. Merged and pushed afw and the minor changes to meas_algorithms and meas_astrom.

            Show
            rowen Russell Owen added a comment - Thank you for the quick review. Merged and pushed afw and the minor changes to meas_algorithms and meas_astrom.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Tim Jenness
                Watchers:
                Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: