Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4609

Partition package should use the standard package layout

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: partition
    • Labels:
      None

      Description

      The partition package does not build on OS X El Capitan because the package is not laid out in the standard manner and whilst sconsUtils is used most of the default behaviors are over-ridden. This means that fixes implemented for DM-3200 do not migrate over to partition. I think the best approach would be to reorganize the package so that it does build in the normal way.

        Attachments

          Issue Links

          is triggered by

          Bug - A problem which impairs or prevents the functions of the product. DM-3200 Base package fails to build under OS X El Capitan

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2262 Improve build system for sphgeom

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            smonkewitz Serge Monkewitz added a comment -

            Tim, does https://github.com/lsst/partition/pull/2 work for you? The downside of putting a SConscript file into bin/ like I am doing here is that the SConscript file gets installed into the PATH. That's a little weird, but hopefully not a showstopper.

            Show
            smonkewitz Serge Monkewitz added a comment - Tim, does https://github.com/lsst/partition/pull/2 work for you? The downside of putting a SConscript file into bin/ like I am doing here is that the SConscript file gets installed into the PATH. That's a little weird, but hopefully not a showstopper.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thanks. I will take a look at it.

            Show
            tjenness Tim Jenness added a comment - Thanks. I will take a look at it.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This is fantastic. The package builds fine now on El Capitan. Thank you very much for this. The SConscript file in the bin/ directory is unavoidable I think given current package design (short of you putting them in bin.src/ and somehow getting them built into bin/ but I wouldn't worry about it) and it's not an executable file so won't appear in the path.

            Show
            tjenness Tim Jenness added a comment - This is fantastic. The package builds fine now on El Capitan. Thank you very much for this. The SConscript file in the bin/ directory is unavoidable I think given current package design (short of you putting them in bin.src/ and somehow getting them built into bin/ but I wouldn't worry about it) and it's not an executable file so won't appear in the path.
            Hide
            Permalink
            smonkewitz Serge Monkewitz added a comment -

            Thanks for the review!

            Show
            smonkewitz Serge Monkewitz added a comment - Thanks for the review!

              People

              Assignee:
              smonkewitz Serge Monkewitz
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Tim Jenness
              Watchers:
              Serge Monkewitz, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.