Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4616

Migrate Qserv code to stream-based logging

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      Migrate Qserv code from LOGF_* to LOGS_*.

      While doing it, we will also revisit logging levels: in particular we are abusing INFO, most of what is now in INFO should be on DEBUG, in some places where INFO is used to cover unusual conditions, it should go to WARNING.

      Further, we will unify how we initialize logging structures. Per discussions at 2015/12/09 Qserv meeting, we like best

      LOG_LOGGER _log = LOG_GET("lsst.qserv.<module>.<file>")

      in anonymous namespace in cc files. Logging from .hh files is strongly discouraged.

      This involves changing ~600 places.

        Attachments

          Issue Links

            Activity

            Hide
            jbecla Jacek Becla added a comment -

            Andy, can you review. It is pretty large:

            91 files changed, 1052 insertions(+), 1001 deletions(-)

            , but the changes are not overly complicated . Thanks.

            Show
            jbecla Jacek Becla added a comment - Andy, can you review. It is pretty large: 91 files changed, 1052 insertions(+), 1001 deletions(-) , but the changes are not overly complicated . Thanks.
            Hide
            salnikov Andy Salnikov added a comment -

            I'm done reviewing, few comments left in PR. There are very many changes so there is a chance I missed something. Good thing is that if it compiles then it should not crash any more.
            I think John is ready to merge his ticket which has few new logging messages, you will need to re-check it after rebasing.

            Show
            salnikov Andy Salnikov added a comment - I'm done reviewing, few comments left in PR. There are very many changes so there is a chance I missed something. Good thing is that if it compiles then it should not crash any more. I think John is ready to merge his ticket which has few new logging messages, you will need to re-check it after rebasing.

              People

              • Assignee:
                fritzm Fritz Mueller
                Reporter:
                fritzm Fritz Mueller
                Reviewers:
                Andy Salnikov
                Watchers:
                Andy Salnikov, Jacek Becla
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel