Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4670

Add explicit EUPS packages for pyfits dependencies

    Details

    • Team:
      Architecture

      Description

      pyfits depends on two external packages: stsci-distutils and d2to1. These modules were not put in EUPS packages because it may not have been noticed that pyfits attempts to download them itself when it is built.

      Even though these packages are only required at build time and so are not used by the stack itself, it is more reliable to package them up in EUPS so that they can be installed without requiring calls to PyPI. Historically some people have had issues installing the stack because of issues with downloading these packages (generally certificate failures). [see hipchat room Software Development on 2015-12-15 at 1:30pm PST.]

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Two EUPS packages added and pyfits modified to depend on them. I'm open to choosing different names for the two new packages. We have been inconsistent in using python_ or py as a prefix for python packages.

            Show
            tjenness Tim Jenness added a comment - Two EUPS packages added and pyfits modified to depend on them. I'm open to choosing different names for the two new packages. We have been inconsistent in using python_ or py as a prefix for python packages.
            Hide
            Parejkoj John Parejko added a comment -

            I'd suggest not spending too much time on this, if we're going to eventually add astropy, since we'll want to deprecate pyfits for astropy.io.fits eventually.

            Show
            Parejkoj John Parejko added a comment - I'd suggest not spending too much time on this, if we're going to eventually add astropy, since we'll want to deprecate pyfits for astropy.io.fits eventually.
            Hide
            krughoff Simon Krughoff added a comment - - edited

            Tim Jenness Looks good. Two small things.

            1. It turns out you can have a README.md if you have a .tap_package file: see here. I think it's good to have the readme.
            2. Whether you put the readme back or not, if it's not too much trouble, can you get rid of the commits that add the README.md and delete them the very next commit? It just cleans up the history a little.

            Show
            krughoff Simon Krughoff added a comment - - edited Tim Jenness Looks good. Two small things. 1. It turns out you can have a README.md if you have a .tap_package file: see here . I think it's good to have the readme. 2. Whether you put the readme back or not, if it's not too much trouble, can you get rid of the commits that add the README.md and delete them the very next commit? It just cleans up the history a little.
            Hide
            tjenness Tim Jenness added a comment -

            I deliberately did the add on master as the very first commit of the project and the removal on the ticket branch because I wanted the new code to be on a ticket branch. You need a commit in order to be able to create the ticket branch. I'll put the readme back. Of course, if the package itself came with a README.md there would be a problem (which leads us to the discussion on whether eupspkg should be untarring into a sub directory...

            John Parejko It's much easier to add EUPS packages than people think so it only took 20 minutes or so to do it. I agree that it wasn't worth a lot of time.

            Show
            tjenness Tim Jenness added a comment - I deliberately did the add on master as the very first commit of the project and the removal on the ticket branch because I wanted the new code to be on a ticket branch. You need a commit in order to be able to create the ticket branch. I'll put the readme back. Of course, if the package itself came with a README.md there would be a problem (which leads us to the discussion on whether eupspkg should be untarring into a sub directory... John Parejko It's much easier to add EUPS packages than people think so it only took 20 minutes or so to do it. I agree that it wasn't worth a lot of time.
            Hide
            krughoff Simon Krughoff added a comment -

            Sorry, I missed that you needed the commit to branch. Is there really a problem if the package comes with a README.md since it would just replace the one in the LSST git repo on install? Anyway, glad this is done.

            As a side note, I have found that some third party packages are easy and some are hard to EUPS package. It's not always easy to predict. E.g. healpix was a bear, but maybe that's because I didn't push enough back up stream.

            Show
            krughoff Simon Krughoff added a comment - Sorry, I missed that you needed the commit to branch. Is there really a problem if the package comes with a README.md since it would just replace the one in the LSST git repo on install? Anyway, glad this is done. As a side note, I have found that some third party packages are easy and some are hard to EUPS package. It's not always easy to predict. E.g. healpix was a bear, but maybe that's because I didn't push enough back up stream.
            Hide
            tjenness Tim Jenness added a comment -

            The README.md is now retained. All merges done. Will need to publish after buildbot finishes.

            Show
            tjenness Tim Jenness added a comment - The README.md is now retained. All merges done. Will need to publish after buildbot finishes.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Simon Krughoff
                Watchers:
                John Parejko, Michael Wood-Vasey, Simon Krughoff, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel