Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4677

Design Interfaces for Memory Management for Shared Scans

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      Part of the shared scans involve memory management - a system that will be used by Qserv that will manage memory allocation / pin chunks in memory. This story involves designing the API between Qserv and the memory management system.

        Attachments

          Issue Links

            Activity

            Hide
            jgates John Gates added a comment -

            I've made some comments. It looks ok. I'm sure Fritz and Andy have something to add.

            Show
            jgates John Gates added a comment - I've made some comments. It looks ok. I'm sure Fritz and Andy have something to add.
            Hide
            salnikov Andy Salnikov added a comment -

            I read it and left a bunch of not-extremely-useful comments. My biggest complaint is indentation, I feel like I read xrootd sources, but this is supposed to be qserv code

            Show
            salnikov Andy Salnikov added a comment - I read it and left a bunch of not-extremely-useful comments. My biggest complaint is indentation, I feel like I read xrootd sources, but this is supposed to be qserv code
            Hide
            fritzm Fritz Mueller added a comment -

            More picayune formatting comments from me too, in the PR. It seems your editor is stabbing you in the back wrt. indentation and spelling...

            Show
            fritzm Fritz Mueller added a comment - More picayune formatting comments from me too, in the PR. It seems your editor is stabbing you in the back wrt. indentation and spelling...
            Hide
            abh Andy Hanushevsky added a comment -

            Actually, nothing to do with the editor. Indentation is my own issue. Spelling problems come from my keyboard missing keystrokes (e.g. space) and my editor doesn't auto-correct Anyway, last wave of changes pushed but there may be still some unresolved formatting issues if we really want to get into the smallest details.

            Show
            abh Andy Hanushevsky added a comment - Actually, nothing to do with the editor. Indentation is my own issue. Spelling problems come from my keyboard missing keystrokes (e.g. space) and my editor doesn't auto-correct Anyway, last wave of changes pushed but there may be still some unresolved formatting issues if we really want to get into the smallest details.
            Hide
            abh Andy Hanushevsky added a comment -

            Implemented and pushed.

            Show
            abh Andy Hanushevsky added a comment - Implemented and pushed.

              People

              • Assignee:
                abh Andy Hanushevsky
                Reporter:
                fritzm Fritz Mueller
                Reviewers:
                Fritz Mueller, John Gates
                Watchers:
                Andy Hanushevsky, Andy Salnikov, Fritz Mueller, Jacek Becla, John Gates
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel