Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4692

Refactor ProcessCcdTask and sub-tasks

    Details

      Description

      Based on conversation spurred by DM-3881 as discussed on clo, this ticket will refactor ProcessCcdTask to be easier to extend and instrument, easier to understand, and more modular.

      The main work will be to break up ProcessCcdTask into it's component modules and, and reconfigured to meet the requirements as outlined by the clo discussion.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            Paul Price filing a ticket about this sounds like a great idea. I agree that CalibrateTask would be improved if it could throw an exception if any field it was supposed to copy from icSourceCat was missing, and it'll be a quick fix if that ticket goes through.

            Show
            rowen Russell Owen added a comment - - edited Paul Price filing a ticket about this sounds like a great idea. I agree that CalibrateTask would be improved if it could throw an exception if any field it was supposed to copy from icSourceCat was missing, and it'll be a quick fix if that ticket goes through.
            Hide
            jbosch Jim Bosch added a comment -

            I strongly disagree that this a bug: of course the schema should depend on the config parameters. We should never expect the schema to remain constant when a configuration parameter changes - recall that enabling and disabling measurement algorithms are configuration changes, and those make big changes to the schema.

            Show
            jbosch Jim Bosch added a comment - I strongly disagree that this a bug: of course the schema should depend on the config parameters. We should never expect the schema to remain constant when a configuration parameter changes - recall that enabling and disabling measurement algorithms are configuration changes, and those make big changes to the schema.
            Hide
            price Paul Price added a comment -

            Certainly for big changes like the addition of measurement algorithms, schema changes are expected and unavoidable. But I do think we should have the schema robust against small changes like whether we're reserving PSF stars. Counter- arguments welcome on DM-5385.

            Show
            price Paul Price added a comment - Certainly for big changes like the addition of measurement algorithms, schema changes are expected and unavoidable. But I do think we should have the schema robust against small changes like whether we're reserving PSF stars. Counter- arguments welcome on DM-5385 .
            Hide
            rowen Russell Owen added a comment - - edited

            Merged to master. This was a huge task and I want to thank everybody who helped, including Jim Bosch for advice and design work, Hsin-Fang Chiang for trying this out early on DECam data, Paul Price for a big and helpful review, Simon Krughoff for help with shepherding and debugging, Michael Wood-Vasey for validation data and tools, and Colin Slater for heroic work explaining why the results were different than the old code.

            Show
            rowen Russell Owen added a comment - - edited Merged to master. This was a huge task and I want to thank everybody who helped, including Jim Bosch for advice and design work, Hsin-Fang Chiang for trying this out early on DECam data, Paul Price for a big and helpful review, Simon Krughoff for help with shepherding and debugging, Michael Wood-Vasey for validation data and tools, and Colin Slater for heroic work explaining why the results were different than the old code.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Russell Owen Congratulations and thanks for doing all this work!

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Russell Owen Congratulations and thanks for doing all this work!

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                krughoff Simon Krughoff
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, John Swinbank, Michael Wood-Vasey, Paul Price, Russell Owen, Simon Krughoff, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel