Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4756

Support human-friendly Thread ID in logging messages

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Per discussion 1/6/2016, it'd be nice to have a function that generates user-friendly threadId on Linux to simplify debugging.

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            OK, everything is in place now for the next round of reviews. The changes are not huge but I still ask three people to review that (basically everyone involved in the first round).

            With these changes the log will look like this now:

            [2016-02-22T01:14:43.173-0800] [LWP:7981] INFO  mysql-proxy (proxy/mysqlProxy.lua:492) - Sendresult 0
            

            I also made few small improvements to log package itself which are not directly related to this ticket.

            Show
            salnikov Andy Salnikov added a comment - OK, everything is in place now for the next round of reviews. The changes are not huge but I still ask three people to review that (basically everyone involved in the first round). With these changes the log will look like this now: [2016-02-22T01:14:43.173-0800] [LWP:7981] INFO mysql-proxy (proxy/mysqlProxy.lua:492) - Sendresult 0 I also made few small improvements to log package itself which are not directly related to this ticket.
            Hide
            abh Andy Hanushevsky added a comment -

            OK, I reviewed this. Except for the lwp ID comment, I didn't see anything that worried me.

            Show
            abh Andy Hanushevsky added a comment - OK, I reviewed this. Except for the lwp ID comment, I didn't see anything that worried me.
            Hide
            fritzm Fritz Mueller added a comment - - edited

            I took a look, and left some minor comments/q's in the PR. Kian-Tat Lim please move to "reviewed" after you've had a look. Thanks!

            Show
            fritzm Fritz Mueller added a comment - - edited I took a look, and left some minor comments/q's in the PR. Kian-Tat Lim please move to "reviewed" after you've had a look. Thanks!
            Hide
            salnikov Andy Salnikov added a comment -

            We briefly talked with K-T at JTM about this and K-T said he thinks it's OK and that no one else besides qserv is not going to use this feature anyways. So I'm going to merge everything without waiting for explicit K-T's OK. All comments from Andy and Fritz have been addressed.

            Show
            salnikov Andy Salnikov added a comment - We briefly talked with K-T at JTM about this and K-T said he thinks it's OK and that no one else besides qserv is not going to use this feature anyways. So I'm going to merge everything without waiting for explicit K-T's OK. All comments from Andy and Fritz have been addressed.
            Hide
            salnikov Andy Salnikov added a comment -

            Merged and pushed to master, done.

            Show
            salnikov Andy Salnikov added a comment - Merged and pushed to master, done.

              People

              • Assignee:
                salnikov Andy Salnikov
                Reporter:
                fritzm Fritz Mueller
                Reviewers:
                Andy Hanushevsky, Fritz Mueller, Kian-Tat Lim
                Watchers:
                Andy Hanushevsky, Andy Salnikov, Fritz Mueller, Jacek Becla, Kian-Tat Lim
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel