Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4798

DetectCoaddSourcesTask.scaleVariance gets wrong result

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      DetectCoaddSourcesTask.scaleVariance is used to adjust the variance plane in the coadd to match the observed variance in the image plane (necessary after warping because we've lost variance into covariance). The current implementation produces the wrong scaling in cases where the image has strongly variable variance (e.g., 10 inputs contributed to half the image, but only 1 input contributed to the other half) because it calculates the variance of the image and the mean of the variance separately so that clipping can affect different pixels.

      Getting this scaling very wrong can make us dig into the dirt when detecting objects, with drastic implications for the resultant catalog.

      This is a port of HSC-1357 and HSC-1383.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            Hey Lauren MacArthur, would you mind reviewing this please? It's pretty much a straightforward cherry-pick from the HSC tickets above. Code on pipe_tasks PR #26. Successful Jenkins build #7273.

            Show
            swinbank John Swinbank added a comment - Hey Lauren MacArthur , would you mind reviewing this please? It's pretty much a straightforward cherry-pick from the HSC tickets above. Code on pipe_tasks PR #26 . Successful Jenkins build #7273 .
            Hide
            lauren Lauren MacArthur added a comment -

            This looks fine. My only suggestion would be to add some detail to the commit message for 22ea5c7 as to what is meant by "the calculation is performed on a single image" (I find it a bit cryptic as is). Either way, feel free to merge to master.

            Show
            lauren Lauren MacArthur added a comment - This looks fine. My only suggestion would be to add some detail to the commit message for 22ea5c7 as to what is meant by "the calculation is performed on a single image" (I find it a bit cryptic as is). Either way, feel free to merge to master.
            Hide
            swinbank John Swinbank added a comment -

            Thanks – I tweaked the wording slightly and merged.

            Show
            swinbank John Swinbank added a comment - Thanks – I tweaked the wording slightly and merged.
            Hide
            swinbank John Swinbank added a comment -
            Show
            swinbank John Swinbank added a comment - Updated release notes .

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Lauren MacArthur
              Watchers:
              John Swinbank, Lauren MacArthur
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.