Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4816

Please add a way to get a Filter's canonical name

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      0.25
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6, DRP W16-7
    • Team:
      Data Release Production

      Description

      We support aliases for filters (e.g. NAOJ calls Sloan r "W-S-R+"), but there's no way to ask for the canonical name of a filter. Please rectify this.

      (This issue originally filed by Robert Lupton as Trac #2113; refer to further discussion there.)

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3518 prune stale obs_subaru dependencies

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Vishal Kasliwal [X], can I trouble you for a brief review please? All work is on the pull requests in afw (#49) and obs_subaru (#12). Note that the obs_subaru PR is relative to tickets/DM-3518 – this can't be merged until after that ticket has gone in, but, since it's already passed review, I don't think that should be any cause for concern.

            The work on afw has already been reviewed by Simon Krughoff a couple of years ago, and it looks fine to me. However, since that review is very old, please satisfy yourself that nothing has changed in the codebase which renders it invalid.

            Show
            swinbank John Swinbank added a comment - Vishal Kasliwal [X] , can I trouble you for a brief review please? All work is on the pull requests in afw (#49) and obs_subaru (#12) . Note that the obs_subaru PR is relative to tickets/ DM-3518 – this can't be merged until after that ticket has gone in, but, since it's already passed review, I don't think that should be any cause for concern. The work on afw has already been reviewed by Simon Krughoff a couple of years ago, and it looks fine to me. However, since that review is very old, please satisfy yourself that nothing has changed in the codebase which renders it invalid.
            Hide
            Permalink
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Looks good, but please rebase off master before merging.

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Looks good, but please rebase off master before merging.
            Hide
            Permalink
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Looks good but please rebase off master before merging...

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Looks good but please rebase off master before merging...
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Rebased & merged. Thanks!

            Show
            swinbank John Swinbank added a comment - Rebased & merged. Thanks!
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            And added to the release notes.

            Show
            swinbank John Swinbank added a comment - And added to the release notes.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Vishal Kasliwal [X] (Inactive)
              Watchers:
              John Swinbank, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.