Data ManagementIcon indicating the project type

Data Management

Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4831

Add bright object masks to pipeline outputs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      Given per-patch inputs providing 

      id, B, V, R, ra, dec, radius

      for each star to be masked, use this information to set:

      • A bit in the mask plane for each affected pixel
      • A flag in the source catalogues for each object that has a centroid lying within this mask area

      This is a port of HSC-1342 and HSC-1381.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4159 It seems impossible to configure a configuration via a config option

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5460 Allow butler to use python classes without readFits

          • Won't Fix

          Improvement - An improvement or enhancement to an existing feature or task. DM-6031 Create documentation for bright object masks

          • To Do
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            NB I just noticed an undefined variable and added another comment to the obs_subaru PR.

            Show
            swinbank John Swinbank added a comment - NB I just noticed an undefined variable and added another comment to the obs_subaru PR.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            I moved ObjectMaskCatalog into pipe tasks, and have made all the other changes. The repos have been rebased against master, as well as I have verified that they still produce the object mask like the image above. Jenkins has successfully run. Please review the code and let me know if I am good to merge.

            Show
            nlust Nate Lust added a comment - I moved ObjectMaskCatalog into pipe tasks, and have made all the other changes. The repos have been rebased against master, as well as I have verified that they still produce the object mask like the image above. Jenkins has successfully run. Please review the code and let me know if I am good to merge.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks for this. I've taken a look through the code and it looks fine. I really did mean to suggest to move the code into assembleCoadd.py, since it is really only used there; I'm a bit leery of adding another .py file which doesn't actually contain a task into pipe_tasks. However, there's precedent for this (see e.g. colorterms.py) and, as we discussed, there doesn't seem to be a really good place for this code.

            Given that: good to merge.

            Please remember to update the release notes!

            Show
            swinbank John Swinbank added a comment - Thanks for this. I've taken a look through the code and it looks fine. I really did mean to suggest to move the code into assembleCoadd.py , since it is really only used there; I'm a bit leery of adding another .py file which doesn't actually contain a task into pipe_tasks . However, there's precedent for this (see e.g. colorterms.py ) and, as we discussed, there doesn't seem to be a really good place for this code. Given that: good to merge. Please remember to update the release notes!
            Hide
            Permalink
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Added a brief mention in the release notes.

            Show
            swinbank John Swinbank added a comment - Added a brief mention in the release notes.

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                swinbank John Swinbank
                Reviewers:
                John Swinbank
                Watchers:
                John Swinbank, Nate Lust, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel