XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
3
• Sprint:
DRP W16-7
• Team:
Data Release Production

#### Description

Given per-patch inputs providing

 id, B, V, R, ra, dec, radius  

for each star to be masked, use this information to set:

• A bit in the mask plane for each affected pixel
• A flag in the source catalogues for each object that has a centroid lying within this mask area

This is a port of HSC-1342 and HSC-1381.

#### Activity

Hide
John Swinbank added a comment -

NB I just noticed an undefined variable and added another comment to the obs_subaru PR.

Show
John Swinbank added a comment - NB I just noticed an undefined variable and added another comment to the obs_subaru PR.
Hide
Nate Lust added a comment -

I moved ObjectMaskCatalog into pipe tasks, and have made all the other changes. The repos have been rebased against master, as well as I have verified that they still produce the object mask like the image above. Jenkins has successfully run. Please review the code and let me know if I am good to merge.

Show
Nate Lust added a comment - I moved ObjectMaskCatalog into pipe tasks, and have made all the other changes. The repos have been rebased against master, as well as I have verified that they still produce the object mask like the image above. Jenkins has successfully run. Please review the code and let me know if I am good to merge.
Hide
John Swinbank added a comment -

Thanks for this. I've taken a look through the code and it looks fine. I really did mean to suggest to move the code into assembleCoadd.py, since it is really only used there; I'm a bit leery of adding another .py file which doesn't actually contain a task into pipe_tasks. However, there's precedent for this (see e.g. colorterms.py) and, as we discussed, there doesn't seem to be a really good place for this code.

Given that: good to merge.

Please remember to update the release notes!

Show
John Swinbank added a comment - Thanks for this. I've taken a look through the code and it looks fine. I really did mean to suggest to move the code into assembleCoadd.py , since it is really only used there; I'm a bit leery of adding another .py file which doesn't actually contain a task into pipe_tasks . However, there's precedent for this (see e.g. colorterms.py ) and, as we discussed, there doesn't seem to be a really good place for this code. Given that: good to merge. Please remember to update the release notes!
Hide
Nate Lust added a comment -

merged to master

Show
Nate Lust added a comment - merged to master
Hide
John Swinbank added a comment -

Added a brief mention in the release notes.

Show
John Swinbank added a comment - Added a brief mention in the release notes.

#### People

Assignee:
Nate Lust
Reporter:
John Swinbank
Reviewers:
John Swinbank
Watchers:
John Swinbank, Nate Lust, Paul Price