Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4836

Fix logic for applying aperture corrections

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      With the current flow, the aperture corrections are being applied only after all the measurement plugins have run through, independent of their execution order. This results in plugins whose measurements rely on aperture corrected fluxes (i.e. with execution order > APCORR_ORDER) being applied prior to the aperture correction, leading to erroneous results. The only plugin currently affected by this is base_ClassificationExtendedness.

      This ticket involves applying a temporary fix to ensure proper application and order of aperture corrections. However, the problem highlights the fact that the current logic of how and when aperture corrections are applied should be reworked (on another ticket) to be less error-prone.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Yes, that does help. Thank you.

            Reword that comment, and I think you're good to merge. Thanks for answering my questions.

            Show
            Parejkoj John Parejko added a comment - Yes, that does help. Thank you. Reword that comment, and I think you're good to merge. Thanks for answering my questions.
            Hide
            lauren Lauren MacArthur added a comment -

            John Parejko I've made the updated expected data files for the demo. John Swinbank is going to do a double check that all is well before I merge. I assume from the above that you are ok with this, but for completeness' sake, would you mind hitting the "Review Complete" button?

            Show
            lauren Lauren MacArthur added a comment - John Parejko I've made the updated expected data files for the demo. John Swinbank is going to do a double check that all is well before I merge. I assume from the above that you are ok with this, but for completeness' sake, would you mind hitting the "Review Complete" button?
            Hide
            Parejkoj John Parejko added a comment -

            The comments are clearer: this looks good.

            Show
            Parejkoj John Parejko added a comment - The comments are clearer: this looks good.
            Hide
            lauren Lauren MacArthur added a comment -

            Merged to master.

            Show
            lauren Lauren MacArthur added a comment - Merged to master.
            Hide
            swinbank John Swinbank added a comment -

            ...and release notes have been updated. Thanks!

            Show
            swinbank John Swinbank added a comment - ...and release notes have been updated. Thanks!

              People

              • Assignee:
                lauren Lauren MacArthur
                Reporter:
                lauren Lauren MacArthur
                Reviewers:
                John Parejko
                Watchers:
                John Parejko, John Swinbank, Lauren MacArthur, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel