Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4847

Add new blendedness metric

    XMLWordPrintable

    Details

      Description

      HSC-1316 shifts the calculation of blendedness from meas_deblender to meas_algorithms and defines a new blendedness metric in the process. Please port it.

        Attachments

          Issue Links

            Activity

            Hide
            rearmstr Bob Armstrong added a comment -

            Nate, can you review this for me?

            Show
            rearmstr Bob Armstrong added a comment - Nate, can you review this for me?
            Hide
            nlust Nate Lust added a comment -

            I worry a bit about depending on checking if the child is a heavy footprint as a condition for doing work. It seems like this might be a failure point if the footprints or deblenders are changed. I do not know if there is another good way to do it though.

            Show
            nlust Nate Lust added a comment - I worry a bit about depending on checking if the child is a heavy footprint as a condition for doing work. It seems like this might be a failure point if the footprints or deblenders are changed. I do not know if there is another good way to do it though.
            Hide
            rearmstr Bob Armstrong added a comment -

            I agree that it relies on the fact that the current model has children as heavy footprints and parents as footprints. But this is not the only place in our code where we make that assumption.

            Show
            rearmstr Bob Armstrong added a comment - I agree that it relies on the fact that the current model has children as heavy footprints and parents as footprints. But this is not the only place in our code where we make that assumption.
            Hide
            nlust Nate Lust added a comment -

            That is fair enough. Like I said I didn't have a feeling one way or another about that, I just simply wanted to highlight if there was a different way to check then we probably should to future proof things. If not this is fine. Everything looks good to merge to me provided it passes your test, and does not break anything in jenkins. An added test that I think would be good but not required is to run this on some real data (on ci_hsc or your own) just to check against weird failures.

            Show
            nlust Nate Lust added a comment - That is fair enough. Like I said I didn't have a feeling one way or another about that, I just simply wanted to highlight if there was a different way to check then we probably should to future proof things. If not this is fine. Everything looks good to merge to me provided it passes your test, and does not break anything in jenkins. An added test that I think would be good but not required is to run this on some real data (on ci_hsc or your own) just to check against weird failures.
            Hide
            rearmstr Bob Armstrong added a comment -

            Merged to master.

            Show
            rearmstr Bob Armstrong added a comment - Merged to master.
            Hide
            swinbank John Swinbank added a comment -

            Bob Armstrong, could you please add a brief (couple of sentences) note to the release notes explaining what this new blendedness metric actually measures? Thanks!

            Show
            swinbank John Swinbank added a comment - Bob Armstrong , could you please add a brief (couple of sentences) note to the release notes explaining what this new blendedness metric actually measures? Thanks!
            Hide
            swinbank John Swinbank added a comment -

            I see this is now in the release notes – thank you!

            Show
            swinbank John Swinbank added a comment - I see this is now in the release notes – thank you!

              People

              Assignee:
              rearmstr Bob Armstrong
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Nate Lust
              Watchers:
              Bob Armstrong, John Swinbank, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.