Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4849

LDM-151 - comments from Jacek

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Design Documents
    • Labels:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP X16-2
    • Team:
      Data Release Production

      Description

      I am reading your https://github.com/lsst/LDM-151/blob/draft/DM_Applications_Design.tex, and I have some minor comments suggestions. I am going to add comments to this story to capture it. Feel free to apply to ignore

        Attachments

          Activity

          Show
          jbecla Jacek Becla added a comment - https://github.com/lsst/LDM-151/blob/draft/DM_Applications_Design.tex#L406 Capitalize "d" in "design"
          Hide
          jbecla Jacek Becla added a comment -
          Show
          jbecla Jacek Becla added a comment - https://github.com/lsst/LDM-151/blob/draft/DM_Applications_Design.tex#L594 lsst/ap in now in lsst-dm/legacy-ap
          Hide
          swinbank John Swinbank added a comment -

          It's unlikely my PR is going to be merged to the existing document: LDM-151 will be comprehensively re-imagined by scipi-wg. Given that, I'm assigning to Zeljko so this doesn't get lost, but I suspect he'll want to close it as "won't fix" in favour of another approach.

          Show
          swinbank John Swinbank added a comment - It's unlikely my PR is going to be merged to the existing document: LDM-151 will be comprehensively re-imagined by scipi-wg. Given that, I'm assigning to Zeljko so this doesn't get lost, but I suspect he'll want to close it as "won't fix" in favour of another approach.
          Hide
          swinbank John Swinbank added a comment -

          After chatting to Zeljko – I will incorporate Jacek's changes to this document before the rest of the scipi-wg take it on. Have to be done soon.

          Show
          swinbank John Swinbank added a comment - After chatting to Zeljko – I will incorporate Jacek's changes to this document before the rest of the scipi-wg take it on. Have to be done soon.
          Hide
          swinbank John Swinbank added a comment -

          Thanks, Jacek, for your comments. I've pushed the following changes to the draft branch on GitHub. Since the whole document is about to be revised, I don't propose to submit this for review but just mark it as done.

          I'd suggest to reword the abstract line

          Done.

          I'd capitalize "object catalog"

          "Object catalog" not capitalized. We currently don't capitalize consistently throughout the document (we should), and I don't see a compelling reason why this particular usage should be one way or the other.

          "through an interface" - I'd change to plural, we will have multiple interfaces: sql, restful, maybe adql etc.

          Done.

          "Level 3 products will be generated by the users of LSST". I'd also mention that sometimes they will be brought from other surveys (e.g., they are not always "generated by lsst users")

          Reworded by borrowing some text from the DPDD.

          I believe this is the only place where Solar Systems Pipeline is mentioned. It is not on the L1 or L2 list of pipelines. If this is the same as MOPS, let's clarify somewhere, if not, then it is worth introducing/listing

          Changed reference to Solar System Object Pipeline to DayMOPS.

          Capitalize "framework"?

          Done.

          I'd change this to "Process Raw Exposures to Calibrated Exposure*s*". This will require changing the diagram too.

          No change made:

          • Multiple snaps go into a calibrated exposure;
          • The UML use case diagram will likely be removed in future rewrites: I don't intend to expend effort on it now.

          extra space between "pre-" and "commissioning"

          Removed.

          "will be heavy reliance" - did you mean "with heavily reliance"?

          I believe the existing text is correct, so haven't changed it.

          Do we still want to call it "prototype code" given we have been in construction for some time and are building the real thing?

          Changed "prototype" to "work-in-progress".

          Why is "Determination" capitalized here?

          I have no idea. I changed it.

          will builds a histogram --> will build a histogram

          Done.

          missing closing paranthesis

          Fixed.

          Capitalize "d" in "design"

          The "Baseline design" capitalization seems to be in use throughout the document, but it's inconsistent with other usage. I changed it.

          lsst/ap in now in lsst-dm/legacy-ap

          Fixed.

          Show
          swinbank John Swinbank added a comment - Thanks, Jacek, for your comments. I've pushed the following changes to the draft branch on GitHub . Since the whole document is about to be revised, I don't propose to submit this for review but just mark it as done. I'd suggest to reword the abstract line Done. I'd capitalize "object catalog" "Object catalog" not capitalized. We currently don't capitalize consistently throughout the document (we should), and I don't see a compelling reason why this particular usage should be one way or the other. "through an interface" - I'd change to plural, we will have multiple interfaces: sql, restful, maybe adql etc. Done. "Level 3 products will be generated by the users of LSST". I'd also mention that sometimes they will be brought from other surveys (e.g., they are not always "generated by lsst users") Reworded by borrowing some text from the DPDD. I believe this is the only place where Solar Systems Pipeline is mentioned. It is not on the L1 or L2 list of pipelines. If this is the same as MOPS, let's clarify somewhere, if not, then it is worth introducing/listing Changed reference to Solar System Object Pipeline to DayMOPS. Capitalize "framework"? Done. I'd change this to "Process Raw Exposures to Calibrated Exposure*s*". This will require changing the diagram too. No change made: Multiple snaps go into a calibrated exposure; The UML use case diagram will likely be removed in future rewrites: I don't intend to expend effort on it now. extra space between "pre-" and "commissioning" Removed. "will be heavy reliance" - did you mean "with heavily reliance"? I believe the existing text is correct, so haven't changed it. Do we still want to call it "prototype code" given we have been in construction for some time and are building the real thing? Changed "prototype" to "work-in-progress". Why is "Determination" capitalized here? I have no idea. I changed it. will builds a histogram --> will build a histogram Done. missing closing paranthesis Fixed. Capitalize "d" in "design" The "Baseline design" capitalization seems to be in use throughout the document, but it's inconsistent with other usage. I changed it. lsst/ap in now in lsst-dm/legacy-ap Fixed.

            People

            • Assignee:
              swinbank John Swinbank
              Reporter:
              jbecla Jacek Becla
              Watchers:
              Jacek Becla, John Swinbank, Kian-Tat Lim, Tim Jenness
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel