Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4867

scisql build scripts are buggy

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: scisql
    • Labels:
      None

      Description

      The scisql build script logic for MySQL/MariaDB version checking is broken on all platforms. There are also assumptions about shared library naming that do not hold on OS/X, which means that the deployment scripts are likely broken on all platforms other than Linux.

        Attachments

          Activity

          Hide
          smonkewitz Serge Monkewitz added a comment -

          Hi Fabrice,

          Turns out the mysql version checking logic has been busted ever since the build system rewrite that split out deployment from installation. Nobody caught it because I guess we only ever tested using one of the MySQL/Maria versions we match to exactly. Sorry to miss this during the last code review. This ticket fixes that, and allows scisql to be deployed on OS/X. This wasn't working before, because all the scripts assumed that the scisql shared library was named xxx.so, and on OS/X it is xxx.dylib. See this PR for the fix.

          Show
          smonkewitz Serge Monkewitz added a comment - Hi Fabrice, Turns out the mysql version checking logic has been busted ever since the build system rewrite that split out deployment from installation. Nobody caught it because I guess we only ever tested using one of the MySQL/Maria versions we match to exactly. Sorry to miss this during the last code review. This ticket fixes that, and allows scisql to be deployed on OS/X. This wasn't working before, because all the scripts assumed that the scisql shared library was named xxx.so, and on OS/X it is xxx.dylib. See this PR for the fix.
          Hide
          smonkewitz Serge Monkewitz added a comment -

          Merged and tagged scisql 0.3.5

          Show
          smonkewitz Serge Monkewitz added a comment - Merged and tagged scisql 0.3.5

            People

            • Assignee:
              smonkewitz Serge Monkewitz
              Reporter:
              smonkewitz Serge Monkewitz
              Reviewers:
              Fabrice Jammes
              Watchers:
              Fabrice Jammes, Serge Monkewitz
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel