Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4882

base_Variance plugin generates errors in lsst_dm_stack_demo

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      Since DM-4235 was merged, we see a bunch of messages along the lines of:

      processCcd.measurement WARNING: Error in base_Variance.measure on record 427969358631797076: The center is outside the Footprint of the source record
      

      in the output from lsst_dm_stack_demo. (See e.g. here). It's not fatal, but the warnings are disconcerting and could be indicative of a deeper problem.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment - - edited

            Michael Wood-Vasey, would you take a look at this please?

            As above, I've filed an issue re SafeCentroidExtractor in Python (DM-4925) and to investigate failures where the centroid falls outside its associated Footprint (DM-4926).

            On meas_base PR#31 I've overhauled the way that errors are handled in both SingleFrameVariancePlugin and SingleFrameInputCountPlugin. This has the immediate effect of removing the spurious messages that were the original cause of this ticket, but should also make the code more robust and predictable in general. In the process, I've augmented SingleFramePeakCentroidPlugin with a failure flag and used it in unit testing – it's simpler and easier to work with than the NaiveCentroid we were previously using. That's quite a bit of new code, but almost all of it in unit tests.

            Show
            swinbank John Swinbank added a comment - - edited Michael Wood-Vasey , would you take a look at this please? As above, I've filed an issue re SafeCentroidExtractor in Python ( DM-4925 ) and to investigate failures where the centroid falls outside its associated Footprint ( DM-4926 ). On meas_base PR#31 I've overhauled the way that errors are handled in both SingleFrameVariancePlugin and SingleFrameInputCountPlugin . This has the immediate effect of removing the spurious messages that were the original cause of this ticket, but should also make the code more robust and predictable in general. In the process, I've augmented SingleFramePeakCentroidPlugin with a failure flag and used it in unit testing – it's simpler and easier to work with than the NaiveCentroid we were previously using. That's quite a bit of new code, but almost all of it in unit tests.
            Hide
            swinbank John Swinbank added a comment -

            And, by the way, evidence of passing Jenkins run without warning messages: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7/7676//console

            Show
            swinbank John Swinbank added a comment - And, by the way, evidence of passing Jenkins run without warning messages: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7/7676//console
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            This looks good.
            Merge it.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - This looks good. Merge it.
            Hide
            swinbank John Swinbank added a comment -

            Thanks for the speedy review! Merged.

            Show
            swinbank John Swinbank added a comment - Thanks for the speedy review! Merged.
            Hide
            swinbank John Swinbank added a comment -

            No need to add to release notes since these tasks weren't in v11.

            Show
            swinbank John Swinbank added a comment - No need to add to release notes since these tasks weren't in v11.

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Michael Wood-Vasey
                Watchers:
                Hsin-Fang Chiang, Jim Bosch, John Swinbank, Joshua Hoblitt, Michael Wood-Vasey, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel