Fix Version/s: None
Sprint:DRP F16-1, DRP F16-2, DRP F16-3
Team:Data Release Production
DM-4882, we observed a number of centroids measured while running the lsst_dm_stack_demo routines fall outside their associated Footprints. This was seen with both the NaiveCentroid and the SdssCentroid centroiders.
For the purposes of
DM-4882 we quieted the warnings arising from this, but we should investigate why this is happening and, if necessary, weed out small Footprints entirely.
Jim Bosch One thing we didn't settle was whether there should be a default distance from footprint peak test. The code you reviewed does not have this test in place for any of the algorithms. Only the check for inside footprint test is automatically performed. Is that what you had in mind?
Good question. Let's not do it just yet. I imagine a 3-pixel distance would be safe and helpful for the small, spurious objects we've focused on so far, but I'm a bit worried that this would spuriously flag some large objects with shallow profiles.
With GaussianCentroid, out of 4200 sources in 5 bands, the inside check eliminates 687. The maxDistToPeak < 3 eliminates 1031, and contains almost all of the failures in the first test.
The SdssCentroid and NaiveCentroid checks eliminate less than 100 with either test.
Could you take a look at the sources eliminated by the check SdssCentroid centroid only, and just by-eye inspect the 10 with the highest SNR? If those all look like junk or cases where the centroid really did fail, I think we're good to merge.
Probably, but I think that really ought to be a separate issue.