Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4936

Enable validateMatches in ci_hsc

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ci_hsc
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      DRP X16-1, DRP X16-2
    • Team:
      Data Release Production

      Description

      python/lsst/ci/hsc/validate.py in ci_hsc says:

          def validateMatches(self, dataId):
              # XXX lsst.meas.astrom.readMatches is gone!
              return
      

      readMatches (or its successor) should be back in place as of DM-3633. Please enable this test.

        Attachments

          Issue Links

            Activity

            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Oh, sorry, that was an old output log file.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Oh, sorry, that was an old output log file.
            Hide
            lauren Lauren MacArthur added a comment -

            Actually, I do think that message will still appear if you do not have meas_extensions_shapeHSM setup. The message comes from:

            https://github.com/lsst/utils/blob/master/src/Utils.cc#L34
            and
            https://github.com/lsst/obs_subaru/blob/master/config/hsm.py#L11

            when the package is attempted to be enabled by obs_subaru's config files:

            https://github.com/lsst/obs_subaru/blob/master/config/processCcd.py#L59
            https://github.com/lsst/obs_subaru/blob/master/config/hsm.py#L7

            A log message is appropriate to let the user know they won't be getting HSM measurements, but I totally agree that its current format looks a bit of a mess (and is effectively given twice)!

            Might Russell Owen have any advice here?

            Show
            lauren Lauren MacArthur added a comment - Actually, I do think that message will still appear if you do not have meas_extensions_shapeHSM setup. The message comes from: https://github.com/lsst/utils/blob/master/src/Utils.cc#L34 and https://github.com/lsst/obs_subaru/blob/master/config/hsm.py#L11 when the package is attempted to be enabled by obs_subaru 's config files: https://github.com/lsst/obs_subaru/blob/master/config/processCcd.py#L59 https://github.com/lsst/obs_subaru/blob/master/config/hsm.py#L7 A log message is appropriate to let the user know they won't be getting HSM measurements, but I totally agree that its current format looks a bit of a mess (and is effectively given twice)! Might Russell Owen have any advice here?
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Yes, I confirm that I still see these in a new run.

            But Lauren MacArthur, I take your note also as confirmation that this Error message is not related to this present ticket, DM-4936

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Yes, I confirm that I still see these in a new run. But Lauren MacArthur , I take your note also as confirmation that this Error message is not related to this present ticket, DM-4936
            Hide
            lauren Lauren MacArthur added a comment -

            Indeed, the messy message, which should really just print as a warning, is an entirely separate issue and has been present for quite a while.

            Show
            lauren Lauren MacArthur added a comment - Indeed, the messy message, which should really just print as a warning, is an entirely separate issue and has been present for quite a while.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            This looks fine. Merge away.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - This looks fine. Merge away.

              People

              • Assignee:
                lauren Lauren MacArthur
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Michael Wood-Vasey
                Watchers:
                John Swinbank, Lauren MacArthur, Michael Wood-Vasey
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel