Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4991

Save algorithm metadata in multiband.py

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      3
    • Epic Link:
    • Sprint:
      DRP F16-1
    • Team:
      Data Release Production

      Description

      The various Tasks in multiband.py do not attach the self.algMetadata instance attribute to their output tables before writing them out, so we aren't actually saving information like which radii were used for apertures.

      We should also make sure this feature is maintained in the processCcd.py rewrite.

        Attachments

          Issue Links

          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Ok, David Reiss & John Swinbank - the unittest has been added to tests/testCoadds.py Can you guys take a look and see if you're happy?

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Ok, David Reiss & John Swinbank - the unittest has been added to tests/testCoadds.py Can you guys take a look and see if you're happy?
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I've not carefully checked the logic, but the general form of the test looks great to me. Thanks – and sorry David Reiss for hijacking your review!

            Show
            swinbank John Swinbank added a comment - I've not carefully checked the logic, but the general form of the test looks great to me. Thanks – and sorry David Reiss for hijacking your review!
            Hide
            Permalink
            reiss David Reiss added a comment -

            The test looks good to me. Thanks for adding it. I'm happy with this work, feel free to merge after passing it through CI.

            Show
            reiss David Reiss added a comment - The test looks good to me. Thanks for adding it. I'm happy with this work, feel free to merge after passing it through CI.
            Hide
            Permalink
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment -

            Merged to master...

            Show
            vpk24 Vishal Kasliwal [X] (Inactive) added a comment - Merged to master...
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Added to release notes.

            Show
            swinbank John Swinbank added a comment - Added to release notes.

              People

              Assignee:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              David Reiss
              Watchers:
              David Reiss, Jim Bosch, John Swinbank, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.