Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_subaru
-
Labels:None
-
Team:Data Release Production
Description
The upgrade to pyfits 3.4 appears to have broken the defect list construction, which is part of the obs_subaru build:
bin.src/genDefectFits.py:56: PyfitsDeprecationWarning: The new_table function is deprecated as of version 3.3 and may be removed in a future version.
|
|
|
Use :meth:`BinTableHDU.from_columns` for new BINARY tables or :meth:`TableHDU.from_columns` for new ASCII tables instead.
|
table = pyfits.new_table(cols)
|
Traceback (most recent call last):
|
File "bin.src/genDefectFits.py", line 86, in <module>
|
genDefectFits(args.cameraName, args.defectsFile, args.targetDir)
|
File "bin.src/genDefectFits.py", line 58, in genDefectFits
|
table.header.update('NAME', ccd)
|
File "/tigress/pprice/lsstsw/stack/Linux64/pyfits/3.4.0/lib/python/pyfits-3.4-py2.7-linux-x86_64.egg/pyfits/header.py", line 1017, in update
|
'value, and comment string.' % idx)
|
ValueError: Header update sequence item #0 is invalid; the item must either be a 2-tuple containing a keyword and value, or a 3-tuple containing a keyword, value, and comment string.
|
scons: *** [hsc/defects/2013-01-31/defects.dat-fits] Error 1
|
scons: building terminated because of errors.
|
When I hack the environment to use pyfits 3.3, it works fine.
Attachments
Issue Links
Activity
Very nice, thanks.
Paul Price
added a comment - Very nice, thanks. Merged as part of DM-3518.
I've addressed this on
DM-3518, since it broke the test cases I'm trying to merge as part of that ticket. Relevant change is here. Paul Price, can you confirm that you are happy with this fix, please?