Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5030

Tests fail on Qserv on OS X El Capitan because of SIP

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Story Points:
      2
    • Team:
      Architecture

      Description

      OS X El Capitan introduced System Integrity Protection which leads to dangerous environment variables being stripped when executing trusted binaries. Since scons is launched using /usr/bin/env the tests that run do not get to see DYLD_LIBRARY_PATH. This causes them to fail.

      The same fix that was applied to sconsUtils (copying the path information from LSST_LIBRARY_PATH) needs to be applied to the test execution code used by Qserv's private site_scons utility code.

        Attachments

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-4931 Qserv build fails on El Capitan with missing OpenSSL

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-3200 Base package fails to build under OS X El Capitan

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbecla Jacek Becla added a comment -

            Tim, we should change the team, or reassign to someone from the Arch team, i think.

            Show
            jbecla Jacek Becla added a comment - Tim, we should change the team, or reassign to someone from the Arch team, i think.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I've got this. (I forgot that the default assign is to you).

            Show
            tjenness Tim Jenness added a comment - I've got this. (I forgot that the default assign is to you).
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I hope you can take a quick look. See more extensive comments on the pull request.

            Show
            tjenness Tim Jenness added a comment - I hope you can take a quick look. See more extensive comments on the pull request.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Tim, looks OK but I'd use value of $build_dir from SCons env instead of hard-coding it. ALso I'm not sure that you need to change os.environ, as long as you pass it on command line environment does not matter.

            Show
            salnikov Andy Salnikov added a comment - Tim, looks OK but I'd use value of $build_dir from SCons env instead of hard-coding it. ALso I'm not sure that you need to change os.environ , as long as you pass it on command line environment does not matter.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Thanks. I made the suggested improvements and have now merged.

            Show
            tjenness Tim Jenness added a comment - Thanks. I made the suggested improvements and have now merged.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Jacek Becla, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.