Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5050

SingleFrameVariancePlugin takes variance of entire image

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_base
    • Labels:
      None

      Description

      SingleFrameVariancePlugin takes the median variance of the entire image, rather than within an aperture around the source of interest. A Footprint is constructed with the aperture, but it is unused.

      This means that this plugin takes an excessive amount of run time (255/400 sec in a recent run of processCcd on HSC visit=1248 ccd=49 with DM-4692).

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Asking Nate Lust, as original author, to bless this fix:

            pprice@tiger-sumire:/tigress/pprice/dm-4692/meas_base (tickets/DM-5050=) $ git sub
            commit 1e13b9cd3cbc2348f2b9071dfde474f5d2b19215
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Feb 4 16:50:55 2016 -0500
             
                SingleFrameVariancePlugin: measure variance only within aperture
                
                SingleFrameVariancePlugin.measure was taking the median of the
                entire image, rather than within an aperture around the source of
                interest. A Footprint was constructed with the aperture, but was
                unused. Fixed by using a HeavyFootprint to get the pixels within
                the aperture.
                
                Fixing the aperture revealed a problem in the test: all the pixels
                in the aperture were NAN. Found that this was because the source
                was too narrow (has width=2 in the original version in HSC, but was
                somehow changed to 1 here); with a wider source, the aperture is
                larger and includes pixels that are not NAN. Added unmasked NAN
                pixels to test that the median is not being taken from the entire
                image (fails previously, passes now).
             
             python/lsst/meas/base/plugins.py |  5 +++--
             tests/testVariance.py            | 10 ++++++++--
             2 files changed, 11 insertions(+), 4 deletions(-)
            

            Show
            price Paul Price added a comment - Asking Nate Lust , as original author, to bless this fix: pprice@tiger-sumire:/tigress/pprice/dm-4692/meas_base (tickets/DM-5050=) $ git sub commit 1e13b9cd3cbc2348f2b9071dfde474f5d2b19215 Author: Paul Price <price@astro.princeton.edu> Date: Thu Feb 4 16:50:55 2016 -0500   SingleFrameVariancePlugin: measure variance only within aperture SingleFrameVariancePlugin.measure was taking the median of the entire image, rather than within an aperture around the source of interest. A Footprint was constructed with the aperture, but was unused. Fixed by using a HeavyFootprint to get the pixels within the aperture. Fixing the aperture revealed a problem in the test: all the pixels in the aperture were NAN. Found that this was because the source was too narrow (has width=2 in the original version in HSC, but was somehow changed to 1 here); with a wider source, the aperture is larger and includes pixels that are not NAN. Added unmasked NAN pixels to test that the median is not being taken from the entire image (fails previously, passes now).   python/lsst/meas/base/plugins.py | 5 +++-- tests/testVariance.py | 10 ++++++++-- 2 files changed, 11 insertions(+), 4 deletions(-)
            Hide
            nlust Nate Lust added a comment -

            Looks like a good fix to me, and a better unit test. provided it passes jenkins (which I cant see why it would not) then feel free to merge

            Show
            nlust Nate Lust added a comment - Looks like a good fix to me, and a better unit test. provided it passes jenkins (which I cant see why it would not) then feel free to merge
            Hide
            price Paul Price added a comment -

            This fix reduces the runtime of processCcd (with DM-4692) from 400 sec to 91 sec.

            Profile from before:

            Thu Feb  4 14:19:37 2016    profile.dat
             
                     15652366 function calls (15624860 primitive calls) in 400.717 seconds
             
               Ordered by: cumulative time
               List reduced from 8059 to 30 due to restriction <30>
             
               ncalls  tottime  percall  cumtime  percall filename:lineno(function)
                    1    0.001    0.001  400.719  400.719 /tigress/pprice/dm-4692/pipe_tasks/bin/processCcd.py:23(<module>)
                    1    0.000    0.000  397.267  397.267 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:414(parseAndRun)
                    1    0.000    0.000  394.265  394.265 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:173(run)
                   37    0.033    0.001  394.090   10.651 {map}
                    1    0.000    0.000  394.045  394.045 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:294(__call__)
                 44/1    0.003    0.000  393.886  393.886 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/timer.py:114(wrapper)
                    1    0.003    0.003  393.886  393.886 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/processCcd.py:124(run)
                    3    0.001    0.000  377.000  125.667 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:185(run)
                    1    0.000    0.000  376.791  376.791 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:241(run)
                    1    0.000    0.000  375.333  375.333 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:295(calibrate)
                    3    0.007    0.002  352.275  117.425 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:241(measure)
                    5    0.190    0.038  351.203   70.241 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/sfm.py:251(run)
                 6941    0.303    0.000  345.310    0.050 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/baseMeasurement.py:305(callMeasure)
                 3225   70.780    0.022  326.990    0.101 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/plugins.py:180(measure)
                 1910    0.014    0.000  255.821    0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/lib/function_base.py:3001(median)
                 1914    0.038    0.000  255.818    0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/lib/function_base.py:2941(_ureduce)
                 1910    0.110    0.000  255.755    0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/lib/function_base.py:3090(_median)
                 1910    0.030    0.000  255.440    0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/core/fromnumeric.py:554(partition)
                 1914  230.650    0.121  230.650    0.121 {method 'partition' of 'numpy.ndarray' objects}
                 1918   24.766    0.013   24.766    0.013 {method 'flatten' of 'numpy.ndarray' objects}
                    1    0.000    0.000   20.278   20.278 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:220(run)
                    1    0.215    0.215   20.277   20.277 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:238(deblend)
                  218    0.313    0.001   17.950    0.082 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:223(deblend)
                28743    0.075    0.000   17.235    0.001 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/wrappers.py:17(measure)
                    1    0.000    0.000   11.218   11.218 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:236(run)
                    1    0.003    0.003   10.862   10.862 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:282(characterize)
                    2    0.002    0.001    9.428    4.714 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:334(detectMeasureAndEstimatePsf)
                 3716    0.007    0.000    9.360    0.003 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/baseLib.py:3045(measure)
                 3716    9.353    0.003    9.353    0.003 {_baseLib.SdssShapeAlgorithm_measure}
                  218    0.074    0.000    8.612    0.040 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:537(_fitPsfs)
            

            Profile after:

            Thu Feb  4 17:18:33 2016    profile.dat
             
                     15648202 function calls (15620695 primitive calls) in 91.139 seconds
             
               Ordered by: cumulative time
               List reduced from 8081 to 30 due to restriction <30>
             
               ncalls  tottime  percall  cumtime  percall filename:lineno(function)
                    1    0.073    0.073   91.140   91.140 /tigress/pprice/dm-4692/pipe_tasks/bin/processCcd.py:23(<module>)
                    1    0.000    0.000   71.825   71.825 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:414(parseAndRun)
                    1    0.000    0.000   65.862   65.862 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:173(run)
                   37    0.024    0.001   65.639    1.774 {map}
                    1    0.000    0.000   65.602   65.602 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:294(__call__)
                 44/1    0.002    0.000   65.551   65.551 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/timer.py:114(wrapper)
                    1    0.004    0.004   65.551   65.551 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/processCcd.py:124(run)
                    1    0.000    0.000   48.924   48.924 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:241(run)
                    3    0.001    0.000   48.802   16.267 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:185(run)
                    1    0.000    0.000   47.659   47.659 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:295(calibrate)
                    3    0.007    0.002   24.916    8.305 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:241(measure)
                    5    0.176    0.035   24.464    4.893 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/sfm.py:251(run)
                    1    0.000    0.000   19.586   19.586 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:220(run)
                    1    0.236    0.236   19.585   19.585 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:238(deblend)
                 6941    0.228    0.000   18.985    0.003 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/baseMeasurement.py:305(callMeasure)
                    1    0.097    0.097   18.664   18.664 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/processCcd.py:22(<module>)
                  218    0.311    0.001   17.291    0.079 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:223(deblend)
                28743    0.061    0.000   17.236    0.001 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/wrappers.py:17(measure)
                    1    0.140    0.140   16.648   16.648 /tigress/pprice/lsstsw/stack/Linux64/ip_isr/2016_01.0+6/python/lsst/ip/isr/__init__.py:23(<module>)
                    1    0.000    0.000   10.948   10.948 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:236(run)
                    1    0.004    0.004   10.778   10.778 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:282(characterize)
                 3716    0.005    0.000    9.603    0.003 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/baseLib.py:3045(measure)
                 3716    9.598    0.003    9.598    0.003 {_baseLib.SdssShapeAlgorithm_measure}
                    2    0.002    0.001    9.279    4.640 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:334(detectMeasureAndEstimatePsf)
                    1    0.112    0.112    8.692    8.692 /tigress/pprice/lsstsw/stack/Linux64/ip_isr/2016_01.0+6/python/lsst/ip/isr/isr.py:22(<module>)
                    1    0.171    0.171    8.468    8.468 /tigress/pprice/lsstsw/stack/Linux64/meas_algorithms/tickets.DM-4692-g3d073a93d7+1/python/lsst/meas/algorithms/__init__.py:23(<module>)
                  218    0.084    0.000    8.172    0.037 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:537(_fitPsfs)
                    1    0.024    0.024    8.093    8.093 /tigress/pprice/lsstsw/stack/Linux64/meas_algorithms/tickets.DM-4692-g3d073a93d7+1/python/lsst/meas/algorithms/psfDeterminerRegistry.py:22(<module>)
                    1    0.087    0.087    8.069    8.069 /tigress/pprice/lsstsw/stack/Linux64/meas_algorithms/tickets.DM-4692-g3d073a93d7+1/python/lsst/meas/algorithms/pcaPsfDeterminer.py:22(<module>)
                 2650    1.894    0.001    8.035    0.003 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:578(_fitPsf)
            

            Jenkins run is underway; has passed meas_base successfully.

            Show
            price Paul Price added a comment - This fix reduces the runtime of processCcd (with DM-4692 ) from 400 sec to 91 sec. Profile from before: Thu Feb 4 14:19:37 2016 profile.dat   15652366 function calls (15624860 primitive calls) in 400.717 seconds   Ordered by: cumulative time List reduced from 8059 to 30 due to restriction <30>   ncalls tottime percall cumtime percall filename:lineno(function) 1 0.001 0.001 400.719 400.719 /tigress/pprice/dm-4692/pipe_tasks/bin/processCcd.py:23(<module>) 1 0.000 0.000 397.267 397.267 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:414(parseAndRun) 1 0.000 0.000 394.265 394.265 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:173(run) 37 0.033 0.001 394.090 10.651 {map} 1 0.000 0.000 394.045 394.045 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:294(__call__) 44/1 0.003 0.000 393.886 393.886 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/timer.py:114(wrapper) 1 0.003 0.003 393.886 393.886 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/processCcd.py:124(run) 3 0.001 0.000 377.000 125.667 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:185(run) 1 0.000 0.000 376.791 376.791 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:241(run) 1 0.000 0.000 375.333 375.333 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:295(calibrate) 3 0.007 0.002 352.275 117.425 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:241(measure) 5 0.190 0.038 351.203 70.241 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/sfm.py:251(run) 6941 0.303 0.000 345.310 0.050 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/baseMeasurement.py:305(callMeasure) 3225 70.780 0.022 326.990 0.101 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/plugins.py:180(measure) 1910 0.014 0.000 255.821 0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/lib/function_base.py:3001(median) 1914 0.038 0.000 255.818 0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/lib/function_base.py:2941(_ureduce) 1910 0.110 0.000 255.755 0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/lib/function_base.py:3090(_median) 1910 0.030 0.000 255.440 0.134 /tigress/pprice/lsstsw/miniconda/lib/python2.7/site-packages/numpy/core/fromnumeric.py:554(partition) 1914 230.650 0.121 230.650 0.121 {method 'partition' of 'numpy.ndarray' objects} 1918 24.766 0.013 24.766 0.013 {method 'flatten' of 'numpy.ndarray' objects} 1 0.000 0.000 20.278 20.278 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:220(run) 1 0.215 0.215 20.277 20.277 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:238(deblend) 218 0.313 0.001 17.950 0.082 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:223(deblend) 28743 0.075 0.000 17.235 0.001 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/wrappers.py:17(measure) 1 0.000 0.000 11.218 11.218 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:236(run) 1 0.003 0.003 10.862 10.862 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:282(characterize) 2 0.002 0.001 9.428 4.714 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:334(detectMeasureAndEstimatePsf) 3716 0.007 0.000 9.360 0.003 /tigress/pprice/lsstsw/stack/Linux64/meas_base/2016_01.0+6/python/lsst/meas/base/baseLib.py:3045(measure) 3716 9.353 0.003 9.353 0.003 {_baseLib.SdssShapeAlgorithm_measure} 218 0.074 0.000 8.612 0.040 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:537(_fitPsfs) Profile after: Thu Feb 4 17:18:33 2016 profile.dat   15648202 function calls (15620695 primitive calls) in 91.139 seconds   Ordered by: cumulative time List reduced from 8081 to 30 due to restriction <30>   ncalls tottime percall cumtime percall filename:lineno(function) 1 0.073 0.073 91.140 91.140 /tigress/pprice/dm-4692/pipe_tasks/bin/processCcd.py:23(<module>) 1 0.000 0.000 71.825 71.825 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:414(parseAndRun) 1 0.000 0.000 65.862 65.862 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:173(run) 37 0.024 0.001 65.639 1.774 {map} 1 0.000 0.000 65.602 65.602 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/cmdLineTask.py:294(__call__) 44/1 0.002 0.000 65.551 65.551 /tigress/pprice/lsstsw/stack/Linux64/pipe_base/2016_01.0+6/python/lsst/pipe/base/timer.py:114(wrapper) 1 0.004 0.004 65.551 65.551 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/processCcd.py:124(run) 1 0.000 0.000 48.924 48.924 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:241(run) 3 0.001 0.000 48.802 16.267 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:185(run) 1 0.000 0.000 47.659 47.659 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/calibrate.py:295(calibrate) 3 0.007 0.002 24.916 8.305 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/detectAndMeasure.py:241(measure) 5 0.176 0.035 24.464 4.893 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/sfm.py:251(run) 1 0.000 0.000 19.586 19.586 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:220(run) 1 0.236 0.236 19.585 19.585 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/deblend.py:238(deblend) 6941 0.228 0.000 18.985 0.003 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/baseMeasurement.py:305(callMeasure) 1 0.097 0.097 18.664 18.664 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/processCcd.py:22(<module>) 218 0.311 0.001 17.291 0.079 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:223(deblend) 28743 0.061 0.000 17.236 0.001 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/wrappers.py:17(measure) 1 0.140 0.140 16.648 16.648 /tigress/pprice/lsstsw/stack/Linux64/ip_isr/2016_01.0+6/python/lsst/ip/isr/__init__.py:23(<module>) 1 0.000 0.000 10.948 10.948 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:236(run) 1 0.004 0.004 10.778 10.778 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:282(characterize) 3716 0.005 0.000 9.603 0.003 /tigress/pprice/dm-4692/meas_base/python/lsst/meas/base/baseLib.py:3045(measure) 3716 9.598 0.003 9.598 0.003 {_baseLib.SdssShapeAlgorithm_measure} 2 0.002 0.001 9.279 4.640 /tigress/pprice/dm-4692/pipe_tasks/python/lsst/pipe/tasks/characterizeImage.py:334(detectMeasureAndEstimatePsf) 1 0.112 0.112 8.692 8.692 /tigress/pprice/lsstsw/stack/Linux64/ip_isr/2016_01.0+6/python/lsst/ip/isr/isr.py:22(<module>) 1 0.171 0.171 8.468 8.468 /tigress/pprice/lsstsw/stack/Linux64/meas_algorithms/tickets.DM-4692-g3d073a93d7+1/python/lsst/meas/algorithms/__init__.py:23(<module>) 218 0.084 0.000 8.172 0.037 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:537(_fitPsfs) 1 0.024 0.024 8.093 8.093 /tigress/pprice/lsstsw/stack/Linux64/meas_algorithms/tickets.DM-4692-g3d073a93d7+1/python/lsst/meas/algorithms/psfDeterminerRegistry.py:22(<module>) 1 0.087 0.087 8.069 8.069 /tigress/pprice/lsstsw/stack/Linux64/meas_algorithms/tickets.DM-4692-g3d073a93d7+1/python/lsst/meas/algorithms/pcaPsfDeterminer.py:22(<module>) 2650 1.894 0.001 8.035 0.003 /tigress/pprice/lsstsw/stack/Linux64/meas_deblender/2016_01.0+6/python/lsst/meas/deblender/baseline.py:578(_fitPsf) Jenkins run is underway; has passed meas_base successfully.
            Hide
            nlust Nate Lust added a comment -

            Contrary to my previous message, can you add an explanation in the unit test that GaussianPSF wants an odd number, hence the even*x+1 for reference, then feel free to merge

            Show
            nlust Nate Lust added a comment - Contrary to my previous message, can you add an explanation in the unit test that GaussianPSF wants an odd number, hence the even*x+1 for reference, then feel free to merge
            Hide
            price Paul Price added a comment -

            Thanks Nate Lust!

            Added a note on the PSF size (required to be odd) per request on HipChat, and merged to master.

            Show
            price Paul Price added a comment - Thanks Nate Lust ! Added a note on the PSF size (required to be odd) per request on HipChat, and merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Nate Lust
                Watchers:
                Nate Lust, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: