Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5058

Improve and implement crosstalk in ISR

    XMLWordPrintable

    Details

    • Story Points:
      10
    • Epic Link:
    • Sprint:
      Alert Production X16 - 03, Alert Production X16 - 04, Alert Production X16 - 5, Alert Production F16 - 6, Alert Production F16 - 7, Alert Production F16 - 8, Alert Production F16 - 9, Alert Production F16 - 10
    • Team:
      Alert Production

      Description

      ISR needs the following correction algorithms: fringe, crosstalk, overscan (with discontinuity), and non-linearity. Several of these are implemented in HSC and have been ported, but may need some work.

      As noted below this will now only be the crosstalk portion of the ISR upgrades.

        Attachments

          Issue Links

            Activity

            Hide
            ctslater Colin Slater added a comment -

            I pushed an initial copy of Subaru's crosstalk code to this branch.

            Show
            ctslater Colin Slater added a comment - I pushed an initial copy of Subaru's crosstalk code to this branch.
            Hide
            krughoff Simon Krughoff added a comment -

            It makes way more sense to split this into three tickets. That way they can be worked on by more than just one person. Since Colin Slater already pushed crosstalk to this branch, I'm going to capture the crosstalk work here. DM-5462 will be the linearity work. DM-5924 will cover the overscan work. DM-5925 will handle porting the fringe correction code from obs_subaru to ip_isr.

            Show
            krughoff Simon Krughoff added a comment - It makes way more sense to split this into three tickets. That way they can be worked on by more than just one person. Since Colin Slater already pushed crosstalk to this branch, I'm going to capture the crosstalk work here. DM-5462 will be the linearity work. DM-5924 will cover the overscan work. DM-5925 will handle porting the fringe correction code from obs_subaru to ip_isr.
            Hide
            gpdf Gregory Dubois-Felsmann added a comment -

            Can we say that this work is likely to produce a description of the crosstalk correction algorithm and its dependencies (required calibration inputs and required predecessor steps) during this cycle that we could then share with the Camera group so they can evaluate the effort/feasibility of implementing it in the Camera DAQ system?

            Show
            gpdf Gregory Dubois-Felsmann added a comment - Can we say that this work is likely to produce a description of the crosstalk correction algorithm and its dependencies (required calibration inputs and required predecessor steps) during this cycle that we could then share with the Camera group so they can evaluate the effort/feasibility of implementing it in the Camera DAQ system?
            Hide
            swinbank John Swinbank added a comment -

            To what extent is this work a duplicate of DM-11268? I note that :

            • It's not clear from the description above whether this is supposed to cover intra-CCD crosstalk, inter-CCD, or both;
            • Simon Krughoff suggested to me OOB that this issue is "basically done" after Paul Price's work;
            • DM-10299 seems to relate both to this and to DM-11268; Meredith Rawls may have opinions on what she actually needs to complete that ticket.
            • It's unclear if the information Gregory Dubois-Felsmann requested has ever been provided to the Camera Team.

            Thoughts? Simon Krughoff in particular — do you feel you have any work still to do here?

            Show
            swinbank John Swinbank added a comment - To what extent is this work a duplicate of DM-11268 ? I note that : It's not clear from the description above whether this is supposed to cover intra-CCD crosstalk, inter-CCD, or both; Simon Krughoff suggested to me OOB that this issue is "basically done" after Paul Price 's work; DM-10299 seems to relate both to this and to DM-11268 ; Meredith Rawls may have opinions on what she actually needs to complete that ticket. It's unclear if the information Gregory Dubois-Felsmann requested has ever been provided to the Camera Team. Thoughts? Simon Krughoff in particular — do you feel you have any work still to do here?
            Hide
            krughoff Simon Krughoff added a comment -

            I think this can probably be called done. DECam crosstalk is funny and should be handled in obs_decam. The thing that's missing, as you point out, is inter-CCD crosstalk. We definitely need that, but we could have another ticket to specifically add that.

            Show
            krughoff Simon Krughoff added a comment - I think this can probably be called done. DECam crosstalk is funny and should be handled in obs_decam . The thing that's missing, as you point out, is inter-CCD crosstalk. We definitely need that, but we could have another ticket to specifically add that.
            Hide
            swinbank John Swinbank added a comment -

            Ok. Let's close this as a duplicate of DM-11268. Gregory Dubois-Felsmann, I'm not sure how current your request for input to the Camera Team is — perhaps you could open another ticket (or just discuss with me directly) to make sure you have what you need.

            Show
            swinbank John Swinbank added a comment - Ok. Let's close this as a duplicate of DM-11268 . Gregory Dubois-Felsmann , I'm not sure how current your request for input to the Camera Team is — perhaps you could open another ticket (or just discuss with me directly) to make sure you have what you need.

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              krughoff Simon Krughoff
              Watchers:
              Colin Slater, Gregory Dubois-Felsmann, Hsin-Fang Chiang, John Swinbank, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.