# Adapt all HSC calibration data to LSST camera geometry

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
4
• Sprint:
DRP X16-1, DRP X16-2
• Team:
Data Release Production

## Description

In the HSC CCD layout, approximately half of the HSC CCDs are rotated 180 deg with respect to the others, two others have 90 deg rotations and another two have 270 deg rotations. The HSC camera geometry defined a coordinate system where pixel (0, 0) is always the lower-left corner. However, the new camera geometry in the LSST stack does not use this interpretation, preferring to maintain the coordinate system tied to the electronics. As such, accommodations have had to be made for the rotated CCDs on obs_subaru. See DM-4998 and DM-5107 in particular for details. The need for these accommodations, and the accommodations themselves, should be removed. This entails a re-ingestion of the HSC calibration data files (BIAS, DARK, FLAT, etc.) as well as a redefinition of the defects files in obs_subaru.

## Attachments

1. calibs049.png
557 kB
2. compareVisit-v30482-diff_base_PsfFlux-psfMagHist.png
142 kB
3. fringe_fixed.png
529 kB
4. fringe.png
361 kB
5. ratio.png
221 kB

## Activity

Hide
Lauren MacArthur added a comment -

I'm happy if Robert Lupton is! Out of curiosity (and since it matters for our stack comparisons), do you plan to update the flats in the CALIB dir?

Show
Lauren MacArthur added a comment - I'm happy if Robert Lupton is! Out of curiosity (and since it matters for our stack comparisons), do you plan to update the flats in the CALIB dir?
Hide
Paul Price added a comment -

I've finished revising the code. I'm going to do a brief test, and then merge unless I hear any objections. Once that's done we can reorganise the various sets of calibs we've collected over the years. I'll send e-mail about that around the group soon.

Show
Paul Price added a comment - I've finished revising the code. I'm going to do a brief test, and then merge unless I hear any objections. Once that's done we can reorganise the various sets of calibs we've collected over the years. I'll send e-mail about that around the group soon.
Hide
Paul Price added a comment -

Added a couple of commits to pipe_drivers following the review:

 commit 16157718d4f20032bb9edd13e9b92184f49f18fe Author: Paul Price  Date: Mon Apr 18 16:13:01 2016 -0700    constructCalibs: remove workaround for missing in-place stack    We had propagated some code from HSC that was working around the lack of  a version of statisticsStack that operated in-place. We should have that  now, so can remove the workaround.    python/lsst/pipe/drivers/constructCalibs.py | 13 ++++---------  1 file changed, 4 insertions(+), 9 deletions(-)   commit 3192703d5c5c7b15d4ecba12ac56a2158e00be62 Author: Paul Price  Date: Mon Apr 25 16:11:35 2016 -0400    constructCalibs: rename config parameters iter --> nIter    This avoids shadowing the builtin function.    python/lsst/pipe/drivers/constructCalibs.py | 8 ++++----  1 file changed, 4 insertions(+), 4 deletions(-) 

Show
Paul Price added a comment - Added a couple of commits to pipe_drivers following the review: commit 16157718d4f20032bb9edd13e9b92184f49f18fe Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 18 16:13:01 2016 -0700   constructCalibs: remove workaround for missing in-place stack We had propagated some code from HSC that was working around the lack of a version of statisticsStack that operated in-place. We should have that now, so can remove the workaround.   python/lsst/pipe/drivers/constructCalibs.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-)   commit 3192703d5c5c7b15d4ecba12ac56a2158e00be62 Author: Paul Price <price@astro.princeton.edu> Date: Mon Apr 25 16:11:35 2016 -0400   constructCalibs: rename config parameters iter --> nIter This avoids shadowing the builtin function.   python/lsst/pipe/drivers/constructCalibs.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Hide
Lauren MacArthur added a comment - - edited

Robert Lupton noted on HipChat that he is indeed satisfied with the resolution for the flats. Free to merge.

Show
Lauren MacArthur added a comment - - edited Robert Lupton noted on HipChat that he is indeed satisfied with the resolution for the flats. Free to merge.
Hide
Paul Price added a comment -

All merged to master.

Thanks, all!

Show
Paul Price added a comment - All merged to master. Thanks, all!

## People

• Assignee:
Paul Price
Reporter:
Lauren MacArthur
Reviewers:
Lauren MacArthur
Watchers:
John Swinbank, Lauren MacArthur, Paul Price