# B-F correction breaks non-HSC custom ISR, ci_hsc

XMLWordPrintable

#### Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
0.5
• Sprint:
Science Pipelines DM-W16-6
• Team:
Data Release Production

#### Description

The addition of brighter-fatter correction on DM-4837 breaks obs_cfht's custom ISR, since it slightly changes an internal ISR API by addding an argument that isn't expected by the obs_cfht version. It also breaks ci_hsc, since the B-F kernel file isn't included in the calibrations packaged there.

#### Activity

Hide
Jim Bosch added a comment -

Ready for review. Only changes in obs_cfht and ci_hsc, both on tickets/DM-5130 branches. I also inspected obs_decam, obs_lsstSim, and obs_sdss, and I didn't see anything that looked like it needed to be changed.

ci_hsc:

 $git --no-pager log --stat --reverse LSST/master..tickets/DM-5130 commit 5c38bc1f1018df38660bcbf0d07683f3a421eb73 Author: Jim Bosch Date: Thu Feb 11 17:16:30 2016 -0500 Include B-F kernel in calib directory. Eventually, we need to include and run code to generate this kernel, but we don't have that yet, so we just include a static kernel. CALIB/BFKERNEL/brighter_fatter_kernel.pkl | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) obs_cfht: $ git --no-pager log --stat --reverse LSST/master..tickets/DM-5130 commit 715df20b982862f4abee11f5332baca3d8804bb3 Author: Jim Bosch Date: Thu Feb 11 15:05:12 2016 -0500 Update to new interface that includes B-F correction. We don't actually support doing B-F correction on CFHT, but this brings CfhtIsrTask back into compatibility with the rest of the stack. python/lsst/obs/cfht/cfhtIsrTask.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

Show
Jim Bosch added a comment - Ready for review. Only changes in obs_cfht and ci_hsc, both on tickets/ DM-5130 branches. I also inspected obs_decam, obs_lsstSim, and obs_sdss, and I didn't see anything that looked like it needed to be changed. ci_hsc: $git --no-pager log --stat --reverse LSST/master..tickets/DM-5130 commit 5c38bc1f1018df38660bcbf0d07683f3a421eb73 Author: Jim Bosch <jbosch@astro.princeton.edu> Date: Thu Feb 11 17:16:30 2016 -0500 Include B-F kernel in calib directory. Eventually, we need to include and run code to generate this kernel, but we don't have that yet, so we just include a static kernel. CALIB/BFKERNEL/brighter_fatter_kernel.pkl | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) obs_cfht:$ git --no-pager log --stat --reverse LSST/master..tickets/DM-5130 commit 715df20b982862f4abee11f5332baca3d8804bb3 Author: Jim Bosch <jbosch@astro.princeton.edu> Date: Thu Feb 11 15:05:12 2016 -0500   Update to new interface that includes B-F correction. We don't actually support doing B-F correction on CFHT, but this brings CfhtIsrTask back into compatibility with the rest of the stack.   python/lsst/obs/cfht/cfhtIsrTask.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Hide
Michael Wood-Vasey added a comment -

These look good.

I can't actually fully test the ci_hsc integration yet as it's not finding the right astrometry_net files. I will look at this further in the morning, but in the meantime certainly go ahead and merge this ticket into master.

Show
Michael Wood-Vasey added a comment - These look good. I can't actually fully test the ci_hsc integration yet as it's not finding the right astrometry_net files. I will look at this further in the morning, but in the meantime certainly go ahead and merge this ticket into master.
Hide
Jim Bosch added a comment -

You'll need to declare the bundled astrometry_net_data using a version that starts with at least "sdss", then set it up by name (not just in-place by directory). That's another architectural limitation of this package.

Show
Jim Bosch added a comment - You'll need to declare the bundled astrometry_net_data using a version that starts with at least "sdss", then set it up by name (not just in-place by directory). That's another architectural limitation of this package.
Hide
Jim Bosch added a comment -

Merged to master.

Show
Jim Bosch added a comment - Merged to master.

#### People

Assignee:
Jim Bosch
Reporter:
Jim Bosch
Reviewers:
Michael Wood-Vasey
Watchers:
Jim Bosch, Michael Wood-Vasey