Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5135

Make ci_hsc buildable by Jenkins

    Details

      Description

      1. Make sure ci_hsc is buildable by lsstsw / lsst_build
      2. Add ci_hsc to lsstsw/etc/repos.yaml so that one can request that Jenkins builds it.
      3. Verify that the test in ci_hsc fails on known broken tags and passes on known successful tags.

      No dependencies will be added to lsst_sims or lsst_distib.
      This is meant to provide the ability to request that Jenkins do these builds and to fail if something has broken them.

      This will later be expanded to new packages ci_cfht, ci_decam, and ci_sim.

      The key goal is to make sure one hasn't broken obs_ packages in their butler interface or in their processCcd

      Additional Notes and Thoughts from HipChat Discussion
      Kian-Tat Lim
      Sounds good to me; we might have an "lsst_ci" top-level metapackage depending on all of them which is what Jenkins would run regularly.

      If the goal is to test obs_ packages, then my first instinct would be to put that in the obs_ package.
      Longer term goal to test the stack with different precursor datasets.
      If this is testing obs_ packages on a slower cadence than the built-in tests, it's OK for that to be a separate package.

      Jim Bosch
      Eventually, I think we need to run a CI dataset for each camera, then run some camera generic tests on each of those, then run some camera-specific tests on each of those.  So we don't want to go too far down a road in which all tests are camera-specific, but maybe we don't have a choice until we have some better unifying framework for them.
      I've certainly been putting some checks in ci_hsc that would be valid for all other cameras, if we had a CI package for them that went through to coadd processing.

        Attachments

          Issue Links

            Activity

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - The successful build is: https://ci.lsst.codes/job/stack-os-matrix/label=centos-6/8467//console
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Successfully Fails on

            tickets/DM-5135
            tickets/DM-4878 (which was a branch in pipe_tasks that is known to have broken ci_hsc)

            https://ci.lsst.codes/job/stack-os-matrix/8549/label=centos-6/console

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Successfully Fails on tickets/ DM-5135 tickets/ DM-4878 (which was a branch in pipe_tasks that is known to have broken ci_hsc) https://ci.lsst.codes/job/stack-os-matrix/8549/label=centos-6/console
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Quick review.

            ci_hsc now builds under Jenkins.
            See comments for successful build. And for successfully failed build.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Quick review. ci_hsc now builds under Jenkins. See comments for successful build. And for successfully failed build.
            Hide
            price Paul Price added a comment -

            Wonderful!

            Minor quibble, not worth the trouble of fixing: commit summary line should be in the imperative ("Lie to EUPS..." instead of "Lies to EUPS...").

            Show
            price Paul Price added a comment - Wonderful! Minor quibble, not worth the trouble of fixing: commit summary line should be in the imperative ("Lie to EUPS..." instead of "Lies to EUPS...").
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Merged to master.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Merged to master.

              People

              • Assignee:
                wmwood-vasey Michael Wood-Vasey
                Reporter:
                wmwood-vasey Michael Wood-Vasey
                Reviewers:
                Paul Price
                Watchers:
                Michael Wood-Vasey, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel