Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: eigen
-
Labels:None
-
Team:Alert Production
Description
Our current version of eigen (3.2.5) is incompatible with recent versions of SuiteSparse due to a change from UF_long to suitesparse_long. This was fixed in eigen 3.3-beta1, but is a 3-line patch.
I'm going to add the patch to our eigen product, so we won't have to run the 3.3 beta (which may break other things).
Attachments
Issue Links
- blocks
-
DM-5133 Make meas_simastrom a stack package
- Done
Activity
As I said on the PR just now, I was just updating my local checkout and looking at the patches "by hand". I didn't see the squashed version without deleting the branch and re-pulling. I would have preferred two commits for this: one for the upstream patch and one for local mods but probably not worth it now that you've squashed them to one.
Patch merged to master.
There are no story points or epic associated with this ticket. Is that correct?
Correct, and I don't see how to do so now. I marked it as an "improvement", but maybe I should have made it a "story"? It's associated with the "simultaneous astrometry" epic: DM-3869, and was worth 1-2 story points.
Simon Krughoff Can/should you fix that?
And yes, it builds on Jenkins and also fixes the problem I set out to fix related to getting jointcal to build with a more recent SuiteSparse.