Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5197

Test and robustify shapelet PSF approximations

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_modelfit
    • Labels:
      None
    • Story Points:
      8
    • Sprint:
      Science Pipelines DM-W16-6, DRP X16-1, DRP X16-2, DRP X16-3
    • Team:
      Data Release Production

      Description

      The CModel code ported from HSC only works as well as the ShapeletPsfApproximation algorithm that runs before it, but we've switched on the LSST side to a more flexible algorithm that isn't as nearly as battle-tested as what's been running on the HSC side, and there are some concerning indications from Perry Gee's work that it can be catastrophically slow on some reasonable PSFs. On this issue, I'll run it on some real HSC data and try to improve it, even if that means reducing the flexibility back to what was on the HSC side in some ways.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            This isn't strictly porting work from HSC – let's punt it to DM-5346.

            Show
            swinbank John Swinbank added a comment - This isn't strictly porting work from HSC – let's punt it to DM-5346 .
            Hide
            jbosch Jim Bosch added a comment -

            This is now ready for review. Pim Schellart [X], are you up for taking a look at a fairly large chunk of code? I'm fully expecting you to have a lot of questions, and hopefully that will help introduce you to a fair amount of the stack.

            Anyhow, this adds a new algorithm for measuring the shapelet approximations to the PSF model that we use when convolving galaxy models in the CModel algorithm. Most of the code is in meas_modelfit, with some small changes in afw, shapelet, an meas_base as well (mostly fixing small oversights in lower-level classes I'm using in meas_modelfit). Code is on branch tickets/DM-5197 for all of these repos.

            Show
            jbosch Jim Bosch added a comment - This is now ready for review. Pim Schellart [X] , are you up for taking a look at a fairly large chunk of code? I'm fully expecting you to have a lot of questions, and hopefully that will help introduce you to a fair amount of the stack. Anyhow, this adds a new algorithm for measuring the shapelet approximations to the PSF model that we use when convolving galaxy models in the CModel algorithm. Most of the code is in meas_modelfit, with some small changes in afw, shapelet, an meas_base as well (mostly fixing small oversights in lower-level classes I'm using in meas_modelfit). Code is on branch tickets/ DM-5197 for all of these repos.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Ok, I'll take a look at it. And I'll get back to you with many many questions.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Ok, I'll take a look at it. And I'll get back to you with many many questions.
            Hide
            jbosch Jim Bosch added a comment -

            Pim Schellart [X], I've created a GitHub PR for meas_modelfit to help me find all the comments. Please feel free to create one for other packages if you'd like (but the changes are small enough there that I think it's just as likely you won't have anything detailed to say).

            Show
            jbosch Jim Bosch added a comment - Pim Schellart [X] , I've created a GitHub PR for meas_modelfit to help me find all the comments. Please feel free to create one for other packages if you'd like (but the changes are small enough there that I think it's just as likely you won't have anything detailed to say).
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Ok, thanks. I will do that. But note that I'm not finished with meas_modelfit just yet

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Ok, thanks. I will do that. But note that I'm not finished with meas_modelfit just yet
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Minor comments, mostly on clarifying documentation. Looks great otherwise.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Minor comments, mostly on clarifying documentation. Looks great otherwise.
            Hide
            jbosch Jim Bosch added a comment -

            Thanks for the detailed review. I think I've addressed everything, including a big rebase and squash. Just waiting on Jenkins now.

            Show
            jbosch Jim Bosch added a comment - Thanks for the detailed review. I think I've addressed everything, including a big rebase and squash. Just waiting on Jenkins now.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Pim Schellart [X] (Inactive)
              Watchers:
              Jim Bosch, John Swinbank, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: