Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5199

Fail early if the compiler does not support -std=c++11

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: sconsUtils
    • Labels:
      None
    • Story Points:
      0.1
    • Team:
      Architecture

      Description

      In DM-1361 sconsUtils was modified to insist on support C++ 11 features. The tests turned out to be too permissive as some GCC compilers that support -std=c++0x understand some C++ 11 features but not all of them. The proposal is simply to remove the -std=c++0x option and fail if the compiler does not support -std=c++11.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            As discussed on HipChat this afternoon this is a trivial patch to enforce C++ 11 mode without allowing the older "in development" standard. This will allow older GCC compilers to fail out much quicker than now and with a useful error message (otherwise they get to AFW and then complain about nullptr).

            Show
            tjenness Tim Jenness added a comment - As discussed on HipChat this afternoon this is a trivial patch to enforce C++ 11 mode without allowing the older "in development" standard. This will allow older GCC compilers to fail out much quicker than now and with a useful error message (otherwise they get to AFW and then complain about nullptr ).
            Hide
            ktl Kian-Tat Lim added a comment -

            You could have removed the whole loop, but that wouldn't be as minimal.

            Looks good to me, let's not bother Russell.

            Show
            ktl Kian-Tat Lim added a comment - You could have removed the whole loop, but that wouldn't be as minimal. Looks good to me, let's not bother Russell.
            Hide
            tjenness Tim Jenness added a comment -

            Thanks. I thought about removing the loop but then I wondered if there were going to be new items in the future and doing it this way really does localize the change.

            Show
            tjenness Tim Jenness added a comment - Thanks. I thought about removing the loop but then I wondered if there were going to be new items in the future and doing it this way really does localize the change.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Kian-Tat Lim, Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel