Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5265

Turn on bias-jump fix for all CCDs

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_decam
    • Labels:
      None

      Description

      The overscan fix to handle bias jump in an amplifier done in DM-4366 introduced a new config parameter overscanBiasJumpBKP, and the fix is applied for CCDs on the backplanes specified in overscanBiasJumpBKP. Previously, the default is to only fix CCDs on backplanes next to the focus chips. But Merlin Fisher-Levine also see the bias jump features in other CCDs. It would make more sense to turn it on for all CCDs by default.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4366 Improve overscan correction for DECam raw data

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5924 Improve overscan correction

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Super quick review. The only change is the default of a config parameter.

            Or, if we are sure we always want to fit overscan in two pieces for each amplifier, this config parameter overscanBiasJumpBKP becomes meaningless. In that case I can remove it. Any preference?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Super quick review. The only change is the default of a config parameter. Or, if we are sure we always want to fit overscan in two pieces for each amplifier, this config parameter overscanBiasJumpBKP becomes meaningless. In that case I can remove it. Any preference?
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Looks fine.

            I think I'd leave the option in for now. It looks as if there are still other problems with bias subtraction (based on Merlin's travails); after we get them resolved we may want to cleanup all the DECam ISR specialisations.

            Show
            rhl Robert Lupton added a comment - Looks fine. I think I'd leave the option in for now. It looks as if there are still other problems with bias subtraction (based on Merlin's travails); after we get them resolved we may want to cleanup all the DECam ISR specialisations.
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Thank you Robert!

            Changes are merged to master.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thank you Robert! Changes are merged to master.

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Robert Lupton
              Watchers:
              Hsin-Fang Chiang, Merlin Fisher-Levine, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.