Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5272

log package no longer builds on OS X

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: log
    • Labels:
      None

      Description

      The thread-local logging changes from DM-4756 break the log package on OS X:

      scons: Building targets ...
      g++ -o src/Log.os -c -std=c++11 -g -DLSST_LITTLE_ENDIAN=1 -O0 -Wall -Wno-unused-function -fPIC -Iinclude -I/Users/timj/work/lsstsw/stack/DarwinX86/boost/1.59.lsst5+fbf04ba888/include -I/Users/timj/work/lsstsw/stack/DarwinX86/log4cxx/0.10.0.lsst6+1cc8a4a234/include -I/Users/timj/work/lsstsw/miniconda/include/python2.7 src/Log.cc
      src/Log.cc:382:5: error: thread-local storage is not supported for the current target
          thread_local static bool threadInit = false;
          ^
      1 error generated.
      

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            Tim Jenness, I have removed that test from the unit tests, I don't think we should assume anything about what lwpID returns on all possible platforms now or in the future. Please update to the HEAD of the branch and test again.

            If this works for you on OS X could you also review the PR please?

            Show
            salnikov Andy Salnikov added a comment - Tim Jenness , I have removed that test from the unit tests, I don't think we should assume anything about what lwpID returns on all possible platforms now or in the future. Please update to the HEAD of the branch and test again. If this works for you on OS X could you also review the PR please?
            Hide
            tjenness Tim Jenness added a comment -

            Works for me on OS X El Capitan now. Thank you.

            Show
            tjenness Tim Jenness added a comment - Works for me on OS X El Capitan now. Thank you.
            Hide
            salnikov Andy Salnikov added a comment -

            Thanks for review! Merged and pushed to master.

            Show
            salnikov Andy Salnikov added a comment - Thanks for review! Merged and pushed to master.
            Hide
            tjenness Tim Jenness added a comment -

            There are no story points or epic associated with this ticket. Jacek Becla is that correct?

            Show
            tjenness Tim Jenness added a comment - There are no story points or epic associated with this ticket. Jacek Becla is that correct?
            Hide
            jbecla Jacek Becla added a comment -

            and, it wasn't assigned to pmcs-tracked epic. I fixed that. Andy Salnikov, pls add SPs.

            Show
            jbecla Jacek Becla added a comment - and, it wasn't assigned to pmcs-tracked epic. I fixed that. Andy Salnikov , pls add SPs.

              People

              • Assignee:
                salnikov Andy Salnikov
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Tim Jenness
                Watchers:
                Andy Salnikov, Fritz Mueller, Jacek Becla, Kian-Tat Lim, Steve Pietrowicz, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel