Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5281

Port HSC skymap, shapelet changesets to LSST

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: shapelet, skymap
    • Labels:
      None

      Description

      We identified in DM-5162 some changesets that still need to be ported from HSC to LSST:

      • skymap:
        • f83f71718eac5307d575d3113ee3757a63a16de2: Set vertex list in ExplicitTractInfo.
      • shapelet:
        • bb928df3fc2fafe5183e0d075da19994f0af4fc7: Let the value to normalize to be specified in [Multi]ShapeletFunction

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Perry Gee, would you please review these two commits?

            price@price-laptop:~/LSST/shapelet (tickets/DM-5281=) $ git sub
            commit 9b8f33080e7e1778e4bc3a3aab13bee5d6af65f6
            Author: Jim Bosch <jbosch@astro.princeton.edu>
            Date:   Wed Jul 17 16:57:27 2013 -0400
             
                Let the value to normalize to be specified in [Multi]ShapeletFunction
             
             include/lsst/shapelet/MultiShapeletFunction.h | 4 ++--
             include/lsst/shapelet/ShapeletFunction.h      | 4 ++--
             src/MultiShapeletFunction.cc                  | 6 +++---
             src/ShapeletFunction.cc                       | 4 ++--
             4 files changed, 9 insertions(+), 9 deletions(-)
             
             
            price@price-laptop:~/LSST/skymap (tickets/DM-5281=) $ git sub
            commit 0dee8ed02e2e75ddb8083cca0e579b50a7f7f760
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Tue Feb 26 16:56:08 2013 +0900
             
                Set vertex list in ExplicitTractInfo.
             
             python/lsst/skymap/tractInfo.py | 3 +++
             1 file changed, 3 insertions(+)
            

            Show
            price Paul Price added a comment - Perry Gee , would you please review these two commits? price@price-laptop:~/LSST/shapelet (tickets/DM-5281=) $ git sub commit 9b8f33080e7e1778e4bc3a3aab13bee5d6af65f6 Author: Jim Bosch <jbosch@astro.princeton.edu> Date: Wed Jul 17 16:57:27 2013 -0400   Let the value to normalize to be specified in [Multi]ShapeletFunction   include/lsst/shapelet/MultiShapeletFunction.h | 4 ++-- include/lsst/shapelet/ShapeletFunction.h | 4 ++-- src/MultiShapeletFunction.cc | 6 +++--- src/ShapeletFunction.cc | 4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-)     price@price-laptop:~/LSST/skymap (tickets/DM-5281=) $ git sub commit 0dee8ed02e2e75ddb8083cca0e579b50a7f7f760 Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 26 16:56:08 2013 +0900   Set vertex list in ExplicitTractInfo.   python/lsst/skymap/tractInfo.py | 3 +++ 1 file changed, 3 insertions(+)
            Hide
            pgee Perry Gee added a comment -

            My only question about ExplicitTractInfo is: how did it every work before? _vertexCoordList was just left empty?

            Should setting this list from bbox when vertexCoordList is empty be a default behavior of TractInfo __init_? Not saying that. Just wondering.

            ShapeletFunction.h and ShapeletFunction.cc – changes are fine.

            If you feel the need for a pull request, let me know. I am not requesting any changes.

            Show
            pgee Perry Gee added a comment - My only question about ExplicitTractInfo is: how did it every work before? _vertexCoordList was just left empty? Should setting this list from bbox when vertexCoordList is empty be a default behavior of TractInfo __init _? Not saying that. Just wondering. ShapeletFunction.h and ShapeletFunction.cc – changes are fine. If you feel the need for a pull request, let me know. I am not requesting any changes.
            Hide
            price Paul Price added a comment -

            I don't think the _vertexCoordList is really used much: I haven't been able to find any code that uses it, and I can't remember what prompted this change. But setting it to something should be preferred to leaving it empty. I don't think it's the base class' job to set it, because it's the subclass that's providing the empty vertexCoordList, and setting the bbox using a different method. It's just that we forgot when writing the subclass to actually set it when done.

            Show
            price Paul Price added a comment - I don't think the _vertexCoordList is really used much: I haven't been able to find any code that uses it, and I can't remember what prompted this change. But setting it to something should be preferred to leaving it empty. I don't think it's the base class' job to set it, because it's the subclass that's providing the empty vertexCoordList , and setting the bbox using a different method. It's just that we forgot when writing the subclass to actually set it when done.
            Hide
            price Paul Price added a comment -

            Merged to master.

            Show
            price Paul Price added a comment - Merged to master.

              People

              Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Perry Gee
              Watchers:
              Paul Price, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.