Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5282

Port HSC meas_algorithms changesets to LSST

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None

      Description

      We identified in DM-5162 several changesets that still need to be ported from HSC to LSST:

      • 1293a31c19c238ba2c2acd8f67ec1be742764b66: BinnedWcs
      • 9f392b134502f6e4fbbd8759806b15f89a267e5a: detection: additional debugging plots for background
      • ad74fe8595ec523d6269e36ec2db051534bf3e9a: Add initial.flags.pixel.interpolated.any to ObjectSizeStarSelectorConfig.badFlags
      • 69f5db0eba69225cff917fa4c96a94dc8b765aa0, 4a0d59e191fc40d3091b56b20cf27ede4e0c23ab: Check for bad PSF measurements (HSC-1153)
      • a54b1ac52678025d3317e8a379c2849d3eb567ba: pcaPsfDeterminer: catch case of no good PSF candidates in debugging
      • c4fcab3251e6f41da2248d63fdf28c0bf80e30f8: Indent seems to be wrong for debug display
      • 2a889c17d47c879dbb4345bafba6aed9869b5984, f3e42cc03ab8a4f1b28d9e0852619cbdbf3b7018: Make IdSpanCompar more deterministic
      • f99eb46f484609673b45290eaaba47688d7b4a24: CR code has to take care of 'NO_DATA' mask
      • 6f6b786bce8ca34bf4c67f75f965130dea027147: Handle small numbers of psfCandidates (HSC-1176)
      • d744e6514feaf67b87068ac502bca677306f9fc2: tests: add test for MeasureApCorrTask
      • 65f617089038fe19179fca4f959bf23ea061a6b8, 1b7e3cc48ed347b0afa31e81c821b38f87d18d64: Test case for measurement of negative objects

      There are also a couple of issues that were identified in the DM-5162 review:

      • Delete tests/config/MeasureSources.py — mere configuration, old-style measurement
      • testPsfDetermination has method 'xtestRejectBlends'

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-92 tests/testPsfDetermination.py has a broken test

          • Invalid
          is parent task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5384 Port SdssShape changes from HSC meas_algorithms to LSST meas_base

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-92 tests/testPsfDetermination.py has a broken test

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5437 Move tests/negative.py from meas_algorithms to meas_base

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5162 Audit the LSST and HSC codebases for differences

          • Done

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            reiss David Reiss added a comment -

            Ok, it is working now. Thanks.

            Show
            reiss David Reiss added a comment - Ok, it is working now. Thanks.
            Hide
            Permalink
            reiss David Reiss added a comment -

            I have added my review comments to a new pull request: https://github.com/lsst/meas_algorithms/pull/21

            Show
            reiss David Reiss added a comment - I have added my review comments to a new pull request: https://github.com/lsst/meas_algorithms/pull/21
            Hide
            Permalink
            nlust Nate Lust added a comment -

            Thanks for the review. I have committed changes to address the issues you mentioned. If you are satisfied with these I will squash them in history before merging to master. It has also been our policy to defer creating the documentation for the HSC port as to not slow down the porting process itself. As such I have filed DM-5526 to address documenting BinnedWcs in our technical debt epic. Pleas let me know if I have missed anything.

            Show
            nlust Nate Lust added a comment - Thanks for the review. I have committed changes to address the issues you mentioned. If you are satisfied with these I will squash them in history before merging to master. It has also been our policy to defer creating the documentation for the HSC port as to not slow down the porting process itself. As such I have filed DM-5526 to address documenting BinnedWcs in our technical debt epic. Pleas let me know if I have missed anything.
            Hide
            Permalink
            reiss David Reiss added a comment -

            All looks good.

            Show
            reiss David Reiss added a comment - All looks good.
            Hide
            Permalink
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              price Paul Price
              Reviewers:
              David Reiss
              Watchers:
              David Reiss, Nate Lust, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: