Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5282

Port HSC meas_algorithms changesets to LSST

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None

      Description

      We identified in DM-5162 several changesets that still need to be ported from HSC to LSST:

      • 1293a31c19c238ba2c2acd8f67ec1be742764b66: BinnedWcs
      • 9f392b134502f6e4fbbd8759806b15f89a267e5a: detection: additional debugging plots for background
      • ad74fe8595ec523d6269e36ec2db051534bf3e9a: Add initial.flags.pixel.interpolated.any to ObjectSizeStarSelectorConfig.badFlags
      • 69f5db0eba69225cff917fa4c96a94dc8b765aa0, 4a0d59e191fc40d3091b56b20cf27ede4e0c23ab: Check for bad PSF measurements (HSC-1153)
      • a54b1ac52678025d3317e8a379c2849d3eb567ba: pcaPsfDeterminer: catch case of no good PSF candidates in debugging
      • c4fcab3251e6f41da2248d63fdf28c0bf80e30f8: Indent seems to be wrong for debug display
      • 2a889c17d47c879dbb4345bafba6aed9869b5984, f3e42cc03ab8a4f1b28d9e0852619cbdbf3b7018: Make IdSpanCompar more deterministic
      • f99eb46f484609673b45290eaaba47688d7b4a24: CR code has to take care of 'NO_DATA' mask
      • 6f6b786bce8ca34bf4c67f75f965130dea027147: Handle small numbers of psfCandidates (HSC-1176)
      • d744e6514feaf67b87068ac502bca677306f9fc2: tests: add test for MeasureApCorrTask
      • 65f617089038fe19179fca4f959bf23ea061a6b8, 1b7e3cc48ed347b0afa31e81c821b38f87d18d64: Test case for measurement of negative objects

      There are also a couple of issues that were identified in the DM-5162 review:

      • Delete tests/config/MeasureSources.py — mere configuration, old-style measurement
      • testPsfDetermination has method 'xtestRejectBlends'

        Attachments

          Issue Links

            Activity

            price Paul Price created issue -
            price Paul Price made changes -
            Field Original Value New Value
            Link This issue relates to DM-5162 [ DM-5162 ]
            nlust Nate Lust made changes -
            Assignee Nate Lust [ nlust ]
            nlust Nate Lust made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            nlust Nate Lust added a comment -

            c4fcab3251e6f41da2248d63fdf28c0bf80e30f8 seems to be already fixed

            Show
            nlust Nate Lust added a comment - c4fcab3251e6f41da2248d63fdf28c0bf80e30f8 seems to be already fixed
            Hide
            nlust Nate Lust added a comment - - edited

            2a889c17d47c879dbb4345bafba6aed9869b5984 Does not need ported
            f3e42cc03ab8a4f1b28d9e0852619cbdbf3b7018 is a fixup for the above and is not needed either

            Show
            nlust Nate Lust added a comment - - edited 2a889c17d47c879dbb4345bafba6aed9869b5984 Does not need ported f3e42cc03ab8a4f1b28d9e0852619cbdbf3b7018 is a fixup for the above and is not needed either
            Hide
            nlust Nate Lust added a comment -

            f99eb46f484609673b45290eaaba47688d7b4a24 is already in lsst

            Show
            nlust Nate Lust added a comment - f99eb46f484609673b45290eaaba47688d7b4a24 is already in lsst
            Hide
            nlust Nate Lust added a comment -

            d744e6514feaf67b87068ac502bca677306f9fc2 Does not need porting, a new unit test for the lsst framework was introduced in DM-2954

            Show
            nlust Nate Lust added a comment - d744e6514feaf67b87068ac502bca677306f9fc2 Does not need porting, a new unit test for the lsst framework was introduced in DM-2954
            nlust Nate Lust made changes -
            Link This issue is parent task of DM-5384 [ DM-5384 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-92 [ DM-92 ]
            nlust Nate Lust made changes -
            Reviewers David Reiss [ reiss ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            swinbank John Swinbank made changes -
            Sprint DRP W16-7 [ 208 ]
            swinbank John Swinbank made changes -
            Epic Link DM-3560 [ 19650 ]
            swinbank John Swinbank made changes -
            Link This issue relates to DM-5437 [ DM-5437 ]
            reiss David Reiss made changes -
            Attachment negative.py.failed [ 27627 ]
            Hide
            reiss David Reiss added a comment -

            I'm getting a test error from tests/negative.py when I try to build this branch, starting with a number of warnings about no Wcs.
            I've attached my negative.py.failed to this ticket.

            ...
            measurement WARNING: Error in base_SkyCoord.measure on record 16: Wcs not attached to exposure.  Required for base_SkyCoord algorithm
            F
            ======================================================================
            FAIL: testBasics (__main__.NegativeMeasurementTestCase)
            ----------------------------------------------------------------------
            Traceback (most recent call last):
              File "tests/negative.py", line 86, in testBasics
                self.assertEqual(nGoodShape, numX * numY)
            AssertionError: 8 != 16
            

            Show
            reiss David Reiss added a comment - I'm getting a test error from tests/negative.py when I try to build this branch, starting with a number of warnings about no Wcs. I've attached my negative.py.failed to this ticket. ... measurement WARNING: Error in base_SkyCoord.measure on record 16: Wcs not attached to exposure. Required for base_SkyCoord algorithm F ====================================================================== FAIL: testBasics (__main__.NegativeMeasurementTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/negative.py", line 86, in testBasics self.assertEqual(nGoodShape, numX * numY) AssertionError: 8 != 16
            Hide
            nlust Nate Lust added a comment -

            Do you have a latest copy meas_base or DM-5384 checked out?

            Show
            nlust Nate Lust added a comment - Do you have a latest copy meas_base or DM-5384 checked out?
            Hide
            reiss David Reiss added a comment -

            Ok, it is working now. Thanks.

            Show
            reiss David Reiss added a comment - Ok, it is working now. Thanks.
            swinbank John Swinbank made changes -
            Sprint DRP W16-7 [ 208 ] DRP W16-7, DRP X16-1 [ 208, 210 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            Hide
            reiss David Reiss added a comment -

            I have added my review comments to a new pull request: https://github.com/lsst/meas_algorithms/pull/21

            Show
            reiss David Reiss added a comment - I have added my review comments to a new pull request: https://github.com/lsst/meas_algorithms/pull/21
            Hide
            nlust Nate Lust added a comment -

            Thanks for the review. I have committed changes to address the issues you mentioned. If you are satisfied with these I will squash them in history before merging to master. It has also been our policy to defer creating the documentation for the HSC port as to not slow down the porting process itself. As such I have filed DM-5526 to address documenting BinnedWcs in our technical debt epic. Pleas let me know if I have missed anything.

            Show
            nlust Nate Lust added a comment - Thanks for the review. I have committed changes to address the issues you mentioned. If you are satisfied with these I will squash them in history before merging to master. It has also been our policy to defer creating the documentation for the HSC port as to not slow down the porting process itself. As such I have filed DM-5526 to address documenting BinnedWcs in our technical debt epic. Pleas let me know if I have missed anything.
            Hide
            reiss David Reiss added a comment -

            All looks good.

            Show
            reiss David Reiss added a comment - All looks good.
            reiss David Reiss made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            reiss David Reiss made changes -
            Comment [ OK, all looks and sounds good to me. ]
            Hide
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master
            nlust Nate Lust made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            nlust Nate Lust made changes -
            Link This issue is duplicated by DM-92 [ DM-92 ]

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                price Paul Price
                Reviewers:
                David Reiss
                Watchers:
                David Reiss, Nate Lust, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: