Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-5283

Port HSC daf_butlerUtils changesets to LSST

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base
    • Labels:
      None

      Description

      We identified in DM-5162 several changesets that still need to be ported from HSC to LSST:

      • daee24edba01b01a0412df7f9b4cf70be5b10860: CameraMapper: allow a default filter name to be provided
      • e3fee95d6a1850dd2309d3ebe4e3ef3ffe38eef0: CameraMapper: normalize path names, and remove leading double slash
      • 476b6ddccd9d0cceb2b89ca34bee7d0fdcd70694: preserve timestamps in cameraMapper.backup()
      • b2491ef60e5e23afa7d9f0297f257e694aa1af35: Only attempt to update Wcs if it's available
      • 9f62bcce588fa9abc8e1e44ff2f0275e5230f629: Registry: hold registry cache for a single thread only (HSC-1035)
      • 412f03b95b7a5e82003ab33a61bd43adbf465188: Registry: use a pool of registries to avoid having too many open files

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            Skipping registry-related commits due to changes on how this is done in LSST.

            Show
            price Paul Price added a comment - Skipping registry-related commits due to changes on how this is done in LSST.
            Hide
            price Paul Price added a comment -

            Nate Pease, would you please review these and ensure they don't conflict with your work?

            price@price-laptop:~/LSST/daf/butlerUtils (tickets/DM-5283 %=) $ git sub
            commit e6f2ac6782959efc4a44d5dd6b447f265474328f
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed Sep 17 16:23:31 2014 -0400
             
                CameraMapper: allow a default filter name to be provided
                
                If provided, an unrecognised filter (filter not in CameraMapper.filters)
                will be replaced by the default filter name.  This will allow processing
                images with filter names that have not been previously anticipated, as
                might be desired for onsite analysis.
             
             python/lsst/daf/butlerUtils/cameraMapper.py | 10 ++++++++--
             1 file changed, 8 insertions(+), 2 deletions(-)
             
            commit 8ae2d705ff6225e15893112d93834dacf598af75
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Wed Sep 3 14:20:19 2014 -0400
             
                CameraMapper: normalize path names, and remove leading double slash
                
                A double leading slash ("//") is significant says POSIX
                (http://stackoverflow.com/a/7816833/834250) but Linux doesn't
                treat it as significant, and CameraMapper doesn't either (apart
                from an infinite loop bug).
             
             python/lsst/daf/butlerUtils/cameraMapper.py | 13 +++++++++++++
             1 file changed, 13 insertions(+)
             
            commit de8c201deaf27348e7d26e92a7b33f3e3805a707
            Author: Steven Bickerton <steven.bickerton@gmail.com>
            Date:   Thu Apr 10 17:07:34 2014 +0900
             
                preserve timestamps in cameraMapper.backup()
             
             python/lsst/daf/butlerUtils/cameraMapper.py | 1 +
             1 file changed, 1 insertion(+)
             
            commit 2dd9f3944865a60c6099f9baf73d2d24e17b7445
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Mon Feb 25 20:47:45 2013 +0900
             
                Only attempt to update Wcs if it's available.
             
             python/lsst/daf/butlerUtils/cameraMapper.py | 3 ++-
             1 file changed, 2 insertions(+), 1 deletion(-)
            

            Show
            price Paul Price added a comment - Nate Pease , would you please review these and ensure they don't conflict with your work? price@price-laptop:~/LSST/daf/butlerUtils (tickets/DM-5283 %=) $ git sub commit e6f2ac6782959efc4a44d5dd6b447f265474328f Author: Paul Price <price@astro.princeton.edu> Date: Wed Sep 17 16:23:31 2014 -0400   CameraMapper: allow a default filter name to be provided If provided, an unrecognised filter (filter not in CameraMapper.filters) will be replaced by the default filter name. This will allow processing images with filter names that have not been previously anticipated, as might be desired for onsite analysis.   python/lsst/daf/butlerUtils/cameraMapper.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)   commit 8ae2d705ff6225e15893112d93834dacf598af75 Author: Paul Price <price@astro.princeton.edu> Date: Wed Sep 3 14:20:19 2014 -0400   CameraMapper: normalize path names, and remove leading double slash A double leading slash ("//") is significant says POSIX (http://stackoverflow.com/a/7816833/834250) but Linux doesn't treat it as significant, and CameraMapper doesn't either (apart from an infinite loop bug).   python/lsst/daf/butlerUtils/cameraMapper.py | 13 +++++++++++++ 1 file changed, 13 insertions(+)   commit de8c201deaf27348e7d26e92a7b33f3e3805a707 Author: Steven Bickerton <steven.bickerton@gmail.com> Date: Thu Apr 10 17:07:34 2014 +0900   preserve timestamps in cameraMapper.backup()   python/lsst/daf/butlerUtils/cameraMapper.py | 1 + 1 file changed, 1 insertion(+)   commit 2dd9f3944865a60c6099f9baf73d2d24e17b7445 Author: Paul Price <price@astro.princeton.edu> Date: Mon Feb 25 20:47:45 2013 +0900   Only attempt to update Wcs if it's available.   python/lsst/daf/butlerUtils/cameraMapper.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
            Hide
            npease Nate Pease added a comment -

            it looks fine to me, does not conflict.

            Show
            npease Nate Pease added a comment - it looks fine to me, does not conflict.
            Hide
            price Paul Price added a comment -

            Thanks Nate Pease.

            A Jenkins run succeeded (its centos-6 sibling failed due to system problems; ignoring that).

            Merged to master.

            Show
            price Paul Price added a comment - Thanks Nate Pease . A Jenkins run succeeded (its centos-6 sibling failed due to system problems; ignoring that). Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Nate Pease
                Watchers:
                Nate Pease, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel